Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper exception handling in the DAGs #14

Open
TAnas0 opened this issue Nov 10, 2020 · 0 comments
Open

Proper exception handling in the DAGs #14

TAnas0 opened this issue Nov 10, 2020 · 0 comments
Labels
2 Simple issue requiring little effort airflow good first issue Good for newcomers refactor Time to restructure some code!

Comments

@TAnas0
Copy link

TAnas0 commented Nov 10, 2020

Currently, certain methods in the DAGs do not have proper error handling.

For example, this pull_survey_cto_data.get_form_data method

def get_form_data(form):
always returns the response from the remote API, regardless if the response is valid, the status code is erroneous...

Acceptance Criteria

Identify parts of the DAG where sensitive requests are being made (remote APIs, DB operations...) and use Python exception handling as you see fit:

  • wrap in try/except blocks
  • log the exception using logger.exception(e)
  • ...
@andrewtpham andrewtpham added the refactor Time to restructure some code! label Nov 10, 2020
@TAnas0 TAnas0 added 2 Simple issue requiring little effort good first issue Good for newcomers labels Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 Simple issue requiring little effort airflow good first issue Good for newcomers refactor Time to restructure some code!
Projects
None yet
Development

No branches or pull requests

2 participants