Create artefact store #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiker
added
enhancement
|
Taking this back, it actually fails some CI tests that I must have missed :( |
jasonjunweilyu
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Hi @hiker , I have reviewed the changes related to this pull request. They all look good to me with only one typo found. As the tests have all passed, I have approved this.
jasonjunweilyu
added
reviewed-with-actions
|
Thanks for the review. I've updated the PR, flake8 and CI seems to be fine. Ready for next review, |
hiker
removed
the
reviewed-with-actions
jasonjunweilyu
approved these changes
Mar 27, 2024
jasonjunweilyu
added
ready-to-be-merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The artefact store is originally just a dict. This introduces a new object that as the artefact store (which inherits from dict, so it behaves the same), but it allows us to add additional methods if required.
It also adds a getter in the BuildConfig (to avoid accessing the private member
self._artefact_store)). I also fixed a few coding style issues (again something we need to figure out :) )