Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files functions #124

Merged
merged 16 commits into from
Jan 15, 2018
Merged

Files functions #124

merged 16 commits into from
Jan 15, 2018

Conversation

hildogjr
Copy link
Owner

No description provided.

@hildogjr
Copy link
Owner Author

hildogjr commented Jan 2, 2018

@xesscorp, merge first "KiCost visual guide" with a lot of improvement and new implementations.
Here I moved the get_html routines to distributors/web_routines.py, but it getting some error in getattr(distributor_imports.

@xesscorp
Copy link
Collaborator

xesscorp commented Jan 3, 2018

Good work! You'll need to clean-up some of these merge conflicts. Then let me know when you think it's ready for a new release on pypi.

@hildogjr
Copy link
Owner Author

hildogjr commented Jan 3, 2018

Unfortunately there is a issue that I don't how to solve yet, it is marked as #TODO in web_routine.py. My intension was remove all the functions related to web from kicost.py to this file (as I did before with the spreadsheet.py).
The issue is related with the distributor_dict and the handle with the sub modules, that have not recognized access now.

@hildogjr
Copy link
Owner Author

hildogjr commented Jan 3, 2018

For a new release (sure, we need to fix this "#TODO") if you could test the graphical interface in other OS (I just tested on Ubuntu python3 but I left ready to work in MAC and Windows) to see if is correctly calling kicost to run and save the configuration to next restart of the application.

Add thread to deal with the update, generating a error when the thread finish.
@xesscorp
Copy link
Collaborator

I tried getting this to work on my Windows 7 PC. Here's what I found before I just gave up:

  1. setup.py requires wx_py >= 3.0. There is no version of wx_py on Pypi that is greater than 0.9.8.12. I'm assuming you meant wxPython >= 3.0?
  2. Line 164 in web_routines.py is print(dir(locals()) has unbalanced parentheses and throws a syntax error.
  3. kicost_gui.py uses tab characters instead of spaces for indentation. I realize this may be automatically generated, but let's try to stick with four spaces instead of tabs for white-space indentation.
  4. Line 60 of kicost_gui.py throws an exception: TypeError: in method 'Window_SetSizeHints', expected argument 2 of type 'int'. I don't know why since this code was autogenerated, Perhaps I'm using the wrong version of wxPython (I'm using 3.0.2.0 with Python 2.7.14). Let me know which version of wxPython you are using and I'll try to continue.

@hildogjr
Copy link
Owner Author

hildogjr commented Jan 12, 2018

@xesscorp thanks by the checking (confidence turn me a collaborator).

  1. You are correct, is wxPython, not wx_py (confusion between the commands to install wx in pip or out, in the Linux terminal). I fixed it (merging in your main branch https://github.com/xesscorp/KiCost/blob/master/setup.py) but leaving it, now, commented because Install kicost without GUI #130. Now, at the first call of kicost GUI will print "install the dependence wxPython" (I do not know how to do pip install kicost just for CLI and for example pip install kicost --gui for CLI + GUIDE, this would be more "professional").

  2. Thanks, it was a noob error. My main intention in this branch is divide the files and leave kicost.py just with the flux control. At web_routines all routines that access the distributors sub modules, something as spreadsheet.py.
    It is some (in my mind) road map to archive Display "extra" component data by the distributor #4 and (after) Automatic specify generic components #17 for C and R.

  3. Fixed.

  4. I am using (now) wxPython 4.0.0a3 on Python3

To be tuned with what I did (because I had changing organization, ...), all structural changes are written in https://github.com/xesscorp/KiCost/blob/master/HISTORY.rst

@xesscorp
Copy link
Collaborator

OK, it's starting to work a little. Thanks! I'll make some more checks and corrections.

@xesscorp xesscorp merged commit bdea977 into hildogjr:master Jan 15, 2018
@hildogjr hildogjr deleted the files-functions branch January 15, 2018 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants