Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handling symlinks for bashrc and zshrc files #80

Merged
merged 2 commits into from
Apr 7, 2019
Merged

fix: handling symlinks for bashrc and zshrc files #80

merged 2 commits into from
Apr 7, 2019

Conversation

matthieusb
Copy link

If you are using symlinks to store your .bashrc or .zshrc file elsewhere, ProxyMan will overwrite them when setting or unsetting them.

With this fix, this will allow people to use symlinks for these configuration files.

@himanshub16
Copy link
Owner

Hi @matthieusb
Sorry for the late reply. I really appreciate your contribution.

GNU sed has --follow-symlink support, but not BSD sed, esp. the one which comes shipped with MacOS by default.

Although, I am not a Mac user, some way to support those who would perhaps be using ProxyMan on Macs would be better.

I found readlink -f and realpath to be a good-choice, and decided to go with readlink -f. more

Since, it has been a delay on my part, I shall fix this on this same branch and merge.

Thanks ☺️

@himanshub16 himanshub16 merged commit 8039ece into himanshub16:master Apr 7, 2019
@himanshub16
Copy link
Owner

Fixes #77

@matthieusb
Copy link
Author

No problem for the delays. I did not know about bsd sed, thanks for the hands up !

And thanks for making your tool available, it is a blessing !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants