Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option ignoring word #15

Merged
merged 4 commits into from
Jul 9, 2019
Merged

Add option ignoring word #15

merged 4 commits into from
Jul 9, 2019

Conversation

himkt
Copy link
Owner

@himkt himkt commented Jul 9, 2019

I introduce the environment variable to enable only the sentence tokenizer by the following command.
TINY_TOKENIZER_BUILD_WORD_TOKENIZER=0 pip install tiny_tokenizer

issue: #14

@himkt himkt changed the title [WIP] Add option ignoring word Add option ignoring word Jul 9, 2019
@himkt himkt self-assigned this Jul 9, 2019
@ikegami-yukino
Copy link

It looks good 👍
But there are 2 kinds of the environment variable name, BUILD_WORD_TOKENIZER in setup.py & .travis.yml and TINY_TOKENIZER_BUILD_WORD_TOKENIZER in README.md
This inconsistency should be fixed.

@himkt himkt force-pushed the add-option-ignoring-word branch from 78d7807 to 2ce53ba Compare July 9, 2019 05:25
@himkt
Copy link
Owner Author

himkt commented Jul 9, 2019

Thanks for the catching!
I fixed documentation and merge it. 🚀

@himkt
Copy link
Owner Author

himkt commented Jul 9, 2019

Build passed. I'll reflect this change in v1.3.1.

@himkt himkt merged commit 44743da into master Jul 9, 2019
@himkt himkt deleted the add-option-ignoring-word branch July 9, 2019 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants