Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: Cannot read property 'url' of undefined #70

Closed
davidhellmann opened this issue Jan 17, 2017 · 5 comments
Closed

TypeError: Cannot read property 'url' of undefined #70

davidhellmann opened this issue Jan 17, 2017 · 5 comments

Comments

@davidhellmann
Copy link

TypeError: Cannot read property 'url' of undefined
 at module.exports (/usr/local/lib/node_modules/git-labelmaker/bin/modules/readRepo.js:13:40)
 at Promise.all.then (/usr/local/lib/node_modules/git-labelmaker/bin/index.js:38:19)

I've a repo with dots like com.foobar.www maybe that's a Problem.
Any Idea how I can fix that?

Node 7.4.0

@himynameisdave
Copy link
Owner

I believe other people have also experienced this issue. Personally I haven't tried it on Node 7+ (but I sort of doubt thats the issue).

I will look more into this, thanks for reporting!

@himynameisdave
Copy link
Owner

@davidhellmann what exactly was your Git url? In your .git/config file, did it look something like this?

[remote "origin"]
	url = git@www.github.com:davidhellmann/repo-name.git

If so, I don't think that test case is being covered in the node-github-url-from-git package we use to parse the git config.

Please respond with the exact git url that gave you trouble and I will file & fix in the appropriate place 👍 😄

@himynameisdave
Copy link
Owner

@davidhellmann re: #70 (comment) do you have a git url for me? If not I may defer this fix until a later release so that I can get 0.9.0 released and out to users when it's stable

@himynameisdave himynameisdave modified the milestones: v0.9.0, v0.9.1 Apr 1, 2017
@himynameisdave
Copy link
Owner

@davidhellmann any chance you can update me re: my comment above ☝️

@himynameisdave
Copy link
Owner

Actually I believe this issue was fixed when #66 was fixed (d46aea6).

Closing, but will reopen if you are still experiencing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants