Eliminate Builder class generation. #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that mixins have been removed, we can simply have the recipes instantiate a Builder.
jessemyers
commented
Feb 1, 2021
| */ | ||
| export function createBuilder<Options>( |
There was a problem hiding this comment.
We now just export a Builder class. Much simpler.
jessemyers
commented
Feb 1, 2021
| } | ||
| public add(...decorators: (PropertyDecorator | undefined)[]): this { | ||
| this.decorators.push( | ||
| ...decorators.filter(isPropertyDecorator), |
There was a problem hiding this comment.
I rewrote this filter to use type guard; this makes the compiler happier if undefined is passed in.
jessemyers
commented
Feb 1, 2021
| export const IsNumber = IsNumberRecipe(createBuilderWithMixins<NumberOptions>()); | ||
| export const IsString = IsStringRecipe(createBuilderWithMixins<StringOptions>()); | ||
| export const IsUUID = IsUUIDRecipe(createBuilderWithMixins<UUIDOptions>()); | ||
| export const IsArray = IsArrayRecipe<FlavorOptions>(initializers); |
There was a problem hiding this comment.
Recipe usage is now just:
- An options type
- A set of initializers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that mixins have been removed, we can simply have the recipes instantiate a Builder.