Added expose to the Open API flavor by default #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessemyers
approved these changes
Aug 2, 2021
IodizedGabe
reviewed
Aug 2, 2021
| // we do not expect any data to be transformed | ||
| expect(Object.keys(obj)).toHaveLength(0); | ||
| // we expect the data to be transformed | ||
| expect(Object.keys(obj).length > 0).toEqual(true); |
There was a problem hiding this comment.
Nit:
Suggested change
| expect(Object.keys(obj).length > 0).toEqual(true); | |
| expect(Object.keys(obj)).toBeGreaterThan(0); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves HIP-29839.
Description:
In one of our libraries there exists a folder
src/typeswhich contains all the DTOs. As it currently stands the fields in the DTOs must explicitly list each field with the @expose decorator.Therefore the purpose of this ticket is to modify @hippo-oss/nest-dto library , and make it so that by default it adds the @expose tag when using @hippo-oss/nest-dto/openapi decorators.
Checklist: