Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add webflux neo4j test #102

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

atomfrede
Copy link
Member

Looks like we have removed/forgot to add again webflux for neo4j into our daily builds. This explains why we didn't noticed this regression earlier.

@mraible
Copy link
Contributor

mraible commented Mar 8, 2021

I believe @pascalgrimaud set things up so daily builds use Protractor, while the main generator's CI process uses Cypress. I'm not sure if that's a hard and fast rule.

@atomfrede
Copy link
Member Author

Good point, was not sure about it, but would make sense.

@pascalgrimaud
Copy link
Member

Yeah, it's because of this : jhipster/generator-jhipster#14103
Once it's solved, I think we can definitively migrate to Cypress for our Daily builds

@atomfrede
Copy link
Member Author

Changed it back. Thanks for the hint.

@pascalgrimaud pascalgrimaud merged commit 235b5ed into hipster-labs:main Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants