-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storybook 8 #251
Storybook 8 #251
Conversation
I did not change the version in package and did not update the changelog |
package.json
Outdated
@@ -72,10 +71,10 @@ | |||
"react": "^18.2.0", | |||
"react-dom": "^18.2.0", | |||
"rimraf": "^3.0.2", | |||
"storybook": "7.0.0", | |||
"storybook": "8.0.0-beta.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to update the version after release
@@ -35,12 +35,11 @@ | |||
"release": "auto shipit" | |||
}, | |||
"dependencies": { | |||
"@storybook/addons": "^7.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@storybook/addons is no longer needed: https://www.npmjs.com/package/@storybook/addons so I remove it
src/icons/Moon.tsx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use icons from @storybook/icons
instead of self-writed. It seems more stable and naturally.
@hipstersmoothie Can you review and merge this? 8.0 has been released. |
Just need to get the version updated here @dartess |
@hipstersmoothie done |
Looks like ci needs to be updated since storybook dropped support for node 16 |
I just tried to up the version. But I'm not familiar with GitHub workflow. |
I checked it in my repository - there are no errors, but there are warnings. I'll try to fix them, but it doesn't seem to be critical. |
@hipstersmoothie |
@dartess I think you are better off doing this in this PR considering it's a pretty small thing. Thanks a lot for your PR 🙏 |
🚀 PR was released in |
Thanks @dartess! |
it looks like it just works.
I tested this in examples and in my main project.
Closed #250