Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook 8 #251

Merged
merged 9 commits into from
Mar 15, 2024
Merged

Storybook 8 #251

merged 9 commits into from
Mar 15, 2024

Conversation

dartess
Copy link
Contributor

@dartess dartess commented Feb 20, 2024

it looks like it just works.
I tested this in examples and in my main project.

Closed #250

@dartess
Copy link
Contributor Author

dartess commented Feb 20, 2024

I did not change the version in package and did not update the changelog

package.json Outdated
@@ -72,10 +71,10 @@
"react": "^18.2.0",
"react-dom": "^18.2.0",
"rimraf": "^3.0.2",
"storybook": "7.0.0",
"storybook": "8.0.0-beta.3",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to update the version after release

@@ -35,12 +35,11 @@
"release": "auto shipit"
},
"dependencies": {
"@storybook/addons": "^7.0.0",
Copy link
Contributor Author

@dartess dartess Feb 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@storybook/addons is no longer needed: https://www.npmjs.com/package/@storybook/addons so I remove it

@dartess dartess marked this pull request as draft February 20, 2024 09:15
@dartess dartess changed the title Draft: Storybook 8 WIP: Storybook 8 Feb 20, 2024
@dartess dartess changed the title WIP: Storybook 8 Storybook 8 Feb 20, 2024
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use icons from @storybook/icons instead of self-writed. It seems more stable and naturally.

@bryanjtc
Copy link

@hipstersmoothie Can you review and merge this? 8.0 has been released.

@hipstersmoothie
Copy link
Owner

Just need to get the version updated here @dartess

@dartess dartess marked this pull request as ready for review March 12, 2024 06:47
@dartess
Copy link
Contributor Author

dartess commented Mar 12, 2024

@hipstersmoothie done

@hipstersmoothie
Copy link
Owner

Looks like ci needs to be updated since storybook dropped support for node 16

@hipstersmoothie hipstersmoothie added the major Increment the major version when merged label Mar 12, 2024
@dartess
Copy link
Contributor Author

dartess commented Mar 12, 2024

I just tried to up the version. But I'm not familiar with GitHub workflow.

@dartess
Copy link
Contributor Author

dartess commented Mar 12, 2024

I checked it in my repository - there are no errors, but there are warnings. I'll try to fix them, but it doesn't seem to be critical.

@dartess
Copy link
Contributor Author

dartess commented Mar 12, 2024

@hipstersmoothie
Now everything will be ok, except for two warnings.
But it seems it will be safe to update to update actions. After this there are no warnings.
I can do it here or in a separate PR later, so as not to slow down the release.

@sshmaxime
Copy link

@dartess I think you are better off doing this in this PR considering it's a pretty small thing. Thanks a lot for your PR 🙏

@hipstersmoothie hipstersmoothie merged commit d2f9880 into hipstersmoothie:master Mar 15, 2024
1 check passed
Copy link

🚀 PR was released in v4.0.0 🚀

@hipstersmoothie
Copy link
Owner

Thanks @dartess!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Increment the major version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook 8
5 participants