Merge pull request #108 from hirak/improve-insight-score

Improve sensiolabs-insight score
hirak · Jun 18, 2016 · 66d37b5 · 66d37b5
2 parents 63fff4a + c5f47a2
commit 66d37b5
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 11 deletions.
diff --git a/composer.lock b/composer.lock
diff --git a/src/CurlRemoteFilesystem.php b/src/CurlRemoteFilesystem.php
@@ -8,7 +8,6 @@
 
 use Composer\Config;
 use Composer\IO;
-use Composer\Downloader;
 use Composer\Util;
 
 class CurlRemoteFilesystem extends Util\RemoteFilesystem

diff --git a/src/FetchRequest.php b/src/FetchRequest.php
@@ -20,7 +20,8 @@ class FetchRequest extends BaseRequest
     );
 
     private $headers = array();
-    private $errno, $error, $info;
+    private $errno;
+    private $error;
 
     /**
      * @param string $url
@@ -68,7 +69,7 @@ public function fetch()
 
         $this->errno = $errno = curl_errno($ch);
         $this->error = curl_error($ch);
-        $this->info = $info = curl_getinfo($ch);
+        $info = curl_getinfo($ch);
 
         if ($errno === CURLE_OK && $info['http_code'] === 200) {
             return $result;

diff --git a/src/Plugin.php b/src/Plugin.php
@@ -10,10 +10,7 @@
 use Composer\IO;
 use Composer\Plugin as CPlugin;
 use Composer\EventDispatcher;
-use Composer\Package;
-use Composer\Script;
 use Composer\Installer;
-use Composer\DependencyResolver;
 
 class Plugin implements
     CPlugin\PluginInterface,
@@ -86,8 +83,6 @@ public static function getSubscribedEvents()
     {
         return array(
             CPlugin\PluginEvents::PRE_FILE_DOWNLOAD => 'onPreFileDownload',
-//            Script\ScriptEvents::POST_ROOT_PACKAGE_INSTALL => 'prefetchComposerRepositories',
-//            Installer\InstallerEvents::PRE_DEPENDENCIES_SOLVING => 'prefetchComposerRepositories',
             Installer\InstallerEvents::POST_DEPENDENCIES_SOLVING => array(
                 array('onPostDependenciesSolving', PHP_INT_MAX),
             ),