Fix issue #27 #31
Fix issue #27 #31
Conversation
|
Similar files are |
2 similar comments
|
Similar files are |
|
Similar files are |
packages/jasmine-auto-spies/src/tests/create-spy-from-class.spec.ts
Outdated
Show resolved
Hide resolved
|
Great job @GuilleEneas ! Please checkout my comments and let me know what you think |
|
Thank you @shairez !!! I had a lot of doubts when implementing in what do. Add this attribute in this type or... btw, first I made that attribute optional, but when calling the error handling method the linter told me that I couldn't use the Also squeezed all commits into one to not pollute the git history 🙂 Please take a look to the final result and let me know if you want me to change anything else. Looking forward to contribute more 🤓 |
packages/jest-auto-spies/src/tests/observable-spy-utils.spec.ts
Outdated
Show resolved
Hide resolved
|
Thanks for the fixes @GuilleEneas ! I've added 2 more comments, please check them out Thanks again! |
…s configured when spy configured with mustBeCalledWith and the method isn't called with the expected parameters, the method name will be displayed in the logs fix #27
|
@shairez, changes implemented 😉 |
It comes from here - So it's not that arbitrary 😀 Here's a nice article about it - Thanks again for making the fix! |
|
@all-contributors please add @GuilleEneas for code and tests |
|
I've put up a pull request to add @GuilleEneas! 🎉 |
|
MERGED! 🎉😀 Thanks again for your contribution 🙏 |
Hi Guys, I don't know what is the protocol here as the issues is already described and we discussed we were going to fix it quickly. Somehow I manage to fix it in all packages just touching the core, therefore only the tests were failing.
I also thought that maybe we could put the name of the method in a more contrasted way, therefore the users will see it better.