Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does this ziegler nichols method works on kettle environment? #3

Open
wonchul-kim opened this issue Dec 21, 2018 · 2 comments
Open

Comments

@wonchul-kim
Copy link

I run your code.

However, it seems that the provided several parameter pairs from the autotune do not work ....
I mean those parameters make convergence eventually, however they are not good parameters...
and I think the brew type works only well as a good parameter tuning.

I assume that brew is assigned by yourself, right?

I have one more question, there are divisor variables in each method, and I don't think they do not quite follow the table in this website: https://en.wikipedia.org/wiki/Ziegler%E2%80%93Nichols_method

How did you come up those divisors?

@dongfangliu
Copy link

@wonchul-kim @hirschmann same question on the devisors. The code's logic is correct.

@diorcety
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants