Skip to content
This repository has been archived by the owner on Sep 8, 2020. It is now read-only.

Fix memory statistics display on FreeBSD/powerpc #871

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix memory statistics display on FreeBSD/powerpc #871

wants to merge 5 commits into from

Commits on Aug 25, 2018

  1. htop.c: remove unused "--io" / "-i" (#811) 

    Introduced from 3383d8e (2.0.0) but never used.
    @LionNatsu @hishamhm
    LionNatsu authored and hishamhm committed Aug 25, 2018
    Configuration menu
    Copy the full SHA
    67e3689 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2018

  1. Remove duplicated if condition 

    The for loop already handles i being < nPanels

Raised by cppcheck
    @alanbarr @hishamhm
    alanbarr authored and hishamhm committed Oct 30, 2018
    Configuration menu
    Copy the full SHA
    c39f710 View commit details
    Browse the repository at this point in the history

  2. Prevent possible NULL pointer deference 

    Raised by cppcheck
    @alanbarr @hishamhm
    alanbarr authored and hishamhm committed Oct 30, 2018
    Configuration menu
    Copy the full SHA
    4cb5846 View commit details
    Browse the repository at this point in the history

  3. Fix printf() unsigned placeholders 

    Unsigned numbers should be using "%u".

Raised by cppcheck
    @alanbarr @hishamhm
    alanbarr authored and hishamhm committed Oct 30, 2018
    Configuration menu
    Copy the full SHA
    b7b4200 View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2018

  1. Fix memory statistics display on FreeBSD/powerpc 

    Use the appropriate types when calling sysctl().

Currently, `unsigned long long int` is used for all sizes and on
FreeBSD/powerpc this causes all sysctl() calls in scanMemoryInfo()
to fail as they are actually of different sizes on powerpc, where
(sizeof(unsigned long long int), sizeof(u_long)) == (8, 4)
vs (8, 8) on amd64.  This results in bogus memory sizes being
reported by htop.

Signed-off-by: Tobias Kortkamp <tobik@FreeBSD.org>
    Tobias Kortkamp authored and Tobias Kortkamp committed Dec 24, 2018
    Configuration menu
    Copy the full SHA
    ecfd6f6 View commit details
    Browse the repository at this point in the history