feat: Preview snap (fix #54) #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for histoire-controls ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for histoire-site ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for histoire-examples-vue3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
hugoattal
changed the title
hugoattal
force-pushed
the
preview-resize
branch
from
b704411
to
b95cb2f
Compare
hugoattal
changed the title
Akryum
reviewed
Apr 9, 2022
| height: finalHeight ? `${finalHeight + 44}px` : null, | ||
| class="htw-h-full htw-p-4 htw-overflow-hidden htw-bg-white dark:htw-bg-gray-700 htw-rounded-lg htw-relative preview-fit" | ||
| :class="isResponsiveEnabled ? { | ||
| 'preview-fit-width': !!finalWidth, |
Akryum
reviewed
Apr 9, 2022
| class="htw-h-full htw-p-4 htw-overflow-hidden htw-bg-white dark:htw-bg-gray-700 htw-rounded-lg htw-relative preview-fit" | ||
| :class="isResponsiveEnabled ? { | ||
| 'preview-fit-width': !!finalWidth, | ||
| 'preview-fit-height': !!finalHeight |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #54
Description
Additional context
I put the
previewSettingsinto the store, that made more sense to me. Wdyt?What is the purpose of this pull request?