Fixed rabbitmq upgrade

[atsikham]

Tasks #1979 #1984. Made it in the one PR as fixes in the same place are necessary.
Tried to find universal way to check clustering and rabbitmq version.

[przemyslavic]

And what about running rabbitmq-diagnostics server_version command to check rabbitmq server version?

root@2334820499a8:/# rabbitmq-diagnostics server_version
Asking node rabbit@2334820499a8 for its RabbitMQ version...
3.8.9

root@fba4e177a16f:/# rabbitmq-diagnostics server_version
Asking node rabbit@fba4e177a16f for its RabbitMQ version...
3.7.10

[atsikham]

Additional comment from @przemyslavic:

What about an upgrade that fails for some reason, but installs new packages before that. The next time the upgrade is started, it will be skipped, because the package version will be up-to-date (and this condition is checked). From what I saw in other components, >= conditions were used just in case the upgrade was interrupted.

[atsikham]

And what about running rabbitmq-diagnostics server_version command to check rabbitmq server version?

root@2334820499a8:/# rabbitmq-diagnostics server_version
Asking node rabbit@2334820499a8 for its RabbitMQ version...
3.8.9

root@fba4e177a16f:/# rabbitmq-diagnostics server_version
Asking node rabbit@fba4e177a16f for its RabbitMQ version...
3.7.10

Used rabbitmqctl instead with json formatter as @sk4zuzu suggested.

[sk4zuzu]

LGTM

[sk4zuzu]

@atsikham dont we need changelog entry here ? 🤔

[atsikham]

@atsikham dont we need changelog entry here ? 🤔

As we had a release and refer to these bugs in the changelog as "known issues", I will update the changelog.

@przemyslavic can we test it somehow before merge?

[przemyslavic]

I'll try to test this PR today. Let's not merge it for now.

[przemyslavic]

/azp run

[atsikham]

Tested manually on aws for clustered and not clustered installations.

[przemyslavic]

@atsikham still doesn't work for v3.7.10:

2021-01-22T12:47:32.7905997Z[38;21m12:47:32 INFO cli.engine.ansible.AnsibleCommand - TASK [upgrade : RabbitMQ | Set facts] ******************************************[0m
2021-01-22T12:47:32.9181086Z[31;21m12:47:32 ERROR cli.engine.ansible.AnsibleCommand - fatal: [ec2-63-35-172-154.eu-west-1.compute.amazonaws.com]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'rabbitmq_version'\n\nThe error appears to be in '/shared/build/06todevawubcanal/ansible/roles/upgrade/tasks/rabbitmq.yml': line 17, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: RabbitMQ | Set facts\n  ^ here\n"}[0m
2021-01-22T12:47:32.9344032Z[31;21m12:47:32 ERROR cli.engine.ansible.AnsibleCommand - fatal: [ec2-18-200-195-163.eu-west-1.compute.amazonaws.com]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'rabbitmq_version'\n\nThe error appears to be in '/shared/build/06todevawubcanal/ansible/roles/upgrade/tasks/rabbitmq.yml': line 17, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: RabbitMQ | Set facts\n  ^ here\n"}

No rabbitmq_version key found in json output.

[atsikham]

/azp run

[to-bar]

How about using lock file approach (upgrade in progress flag file) instead of this condition:
when: rabbitmq_version_current is version(versions.general, '<=')

The flag file is used for example for ZooKeeper, IMO is a smart way 🏃🏻

[przemyslavic]

/azp run

[sk4zuzu]

❤️

[atsikham]

/azp run

[przemyslavic]

@atsikham tested and approved :)