Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add test cases for health check and todo app #78

Merged
merged 3 commits into from
Feb 4, 2024
Merged

feat: add test cases for health check and todo app #78

merged 3 commits into from
Feb 4, 2024

Conversation

shrey-dadhaniya
Copy link
Contributor

@shrey-dadhaniya shrey-dadhaniya commented Feb 2, 2024 •
edited
Loading

added basic setup and test cases for todo app
related to #43

jwala-anirudh
jwala-anirudh requested changes Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@jwala-anirudh jwala-anirudh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work and happy to see your first PR with the code changes. Kindly correct as per the mentioned review comments.

Cheers! 🙂👍🏻

package.json Show resolved Hide resolved
playwright.config.js Outdated Show resolved Hide resolved
e2e/test-server.js Show resolved Hide resolved
e2e/test-server.js Outdated Show resolved Hide resolved
e2e/healthcheck.test.js Outdated Show resolved Hide resolved
e2e/healthcheck.test.js Outdated Show resolved Hide resolved
e2e/healthcheck.test.js Outdated Show resolved Hide resolved
e2e/healthcheck.test.js Outdated Show resolved Hide resolved
e2e/apps/todos.test.js Outdated Show resolved Hide resolved
jwala-anirudh
jwala-anirudh requested changes Feb 4, 2024
View reviewed changes
e2e/routes/healthcheck.test.js Outdated Show resolved Hide resolved
jwala-anirudh
jwala-anirudh approved these changes Feb 4, 2024
View reviewed changes
Copy link
Collaborator

@jwala-anirudh jwala-anirudh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, approved! 🎉

@jwala-anirudh jwala-anirudh merged commit 8b4b42a into hiteshchoudhary:feat/coverage Feb 4, 2024
@shrey-dadhaniya shrey-dadhaniya deleted the feat/coverage-todo-app branch February 4, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwala-anirudh jwala-anirudh jwala-anirudh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shrey-dadhaniya @jwala-anirudh