Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get core and wagon tests to work reliably, various improvements #31

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Get core and wagon tests to work reliably, various improvements #31

merged 1 commit into from
Nov 9, 2021

Conversation

severinraez
Copy link
Contributor

@severinraez severinraez commented Nov 8, 2021 •
edited by carlobeltrame
Loading

See also hitobito/hitobito#1468

  • Use correct ruby version for tests
  • Add setup for core tests, add scripts bin/test_*, update README
  • Fix wagon tests
  • Move wagonfile template to hitobito so local developers use the same setup
  • Add bin/bundle_show, bin/dump_database, bin/load_database, bin/dbconsole
  • Speed up entrypoints
  • Add 'less' to image
  • Update bash prompt when changing branch
  • Simplify debugging
    • Allow skipping entrypoint
    • Do not wrap command in bundle exec so
      docker-compose exec behaves like docker-compose run

Refs hitobito/hitobito#1463

Progress

This was referenced Nov 8, 2021
Merged
Closed
mtnstar
mtnstar requested changes Nov 9, 2021
View reviewed changes
Copy link
Member

@mtnstar mtnstar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice nice nice, our development setup is growing !

maybe make it a bit easier to run specs ?

it also tested it and it works like a charm 👯

README.md Outdated Show resolved Hide resolved
bin/test_env_core Outdated Show resolved Hide resolved
mtnstar
mtnstar reviewed Nov 9, 2021
View reviewed changes
bin/dbconsole Outdated Show resolved Hide resolved
@severinraez
Get core and wagon tests to work reliably, various improvements
f1ffe83 
* Use correct ruby version for tests
* Add setup for core tests, add scripts bin/test_*, update README
* Fix wagon tests
* Move wagonfile template to hitobito so local developers use the same setup
* Add bin/bundle_show, bin/dump_database, bin/load_database, bin/database_console
* Speed up entrypoints
* Add 'less' to image
* Update bash prompt when changing branch
* Simplify debugging
  * Allow skipping entrypoint
  * Do not wrap command in `bundle exec` so
    `docker-compose exec` behaves like `docker-compose run`

Progress
@severinraez severinraez merged commit b4687f9 into master Nov 9, 2021
@severinraez severinraez deleted the sra-wip branch November 9, 2021 10:48
@chrusu chrusu mentioned this pull request May 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtnstar mtnstar mtnstar requested changes

Assignees

@mtnstar mtnstar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@severinraez @mtnstar