Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAC Course state change management #488

Merged
merged 5 commits into from
May 23, 2024
Merged

SAC Course state change management #488

merged 5 commits into from
May 23, 2024

Conversation

TheWalkingLeek
Copy link
Member

@TheWalkingLeek TheWalkingLeek commented Apr 19, 2024 •
edited
Loading

Refs: #362

Requires: hitobito/hitobito#2619

@TheWalkingLeek TheWalkingLeek linked an issue Apr 19, 2024 that may be closed by this pull request
EVENTS: Statuswechsel #362
Closed
4 tasks
codez
codez requested changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@codez codez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das Feld "Status" im Bearbeitenformular soll noch entfernt werden.

config/locales/wagon.de.yml Outdated Show resolved Hide resolved
app/domain/events/courses/state_stepper.rb Outdated Show resolved Hide resolved
@TheWalkingLeek TheWalkingLeek force-pushed the feature/sac_362_course_status branch 5 times, most recently from a2c98a6 to 29845e8 Compare May 3, 2024 07:52
codez
codez requested changes May 3, 2024
View reviewed changes
Copy link
Contributor

@codez codez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich sehe keine Änderung, welche das Status Feld im Formular entfernt (siehe Issue). Fehlt das noch oder kam das woanders mit?

app/controllers/events/courses/state_stepping_controller.rb Outdated Show resolved Hide resolved
@codez codez mentioned this pull request May 21, 2024
Closed
5 tasks
@mtnstar mtnstar force-pushed the feature/sac_362_course_status branch from 5f09291 to 4cf4324 Compare May 22, 2024 08:12
mtnstar pushed a commit to hitobito/hitobito that referenced this pull request May 22, 2024
@TheWalkingLeek
Extract events state form field to separate partial (#2619), refs hit…
a2d3711 
…obito/hitobito_sac_cas#488
@mtnstar mtnstar force-pushed the feature/sac_362_course_status branch from 804f3a5 to 19be8fb Compare May 23, 2024 04:37
mtnstar
mtnstar requested changes May 23, 2024
View reviewed changes
Copy link
Member

@mtnstar mtnstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 🥳
ich habe die review feedbacks gleich selber umgesetzt.
wenn der build dann durchläuft werde ich das feature gleich selber mergen

app/controllers/events/courses/state_stepping_controller.rb Outdated Show resolved Hide resolved
app/controllers/events/courses/state_stepping_controller.rb Outdated Show resolved Hide resolved
app/domain/events/courses/state_stepper.rb Outdated Show resolved Hide resolved
app/controllers/sac_cas/events_controller.rb Outdated Show resolved Hide resolved
app/controllers/events/courses/state_stepping_controller.rb Outdated Show resolved Hide resolved
@mtnstar mtnstar force-pushed the feature/sac_362_course_status branch 6 times, most recently from aab1c7e to 4f63dfb Compare May 23, 2024 12:24
@mtnstar mtnstar force-pushed the feature/sac_362_course_status branch 3 times, most recently from 32a8b6c to c9217a9 Compare May 23, 2024 13:13
@mtnstar mtnstar force-pushed the feature/sac_362_course_status branch from c9217a9 to 233598f Compare May 23, 2024 13:58
@mtnstar mtnstar changed the title Step through course state Course state change management May 23, 2024
@mtnstar mtnstar changed the title Course state change management SAC Course state change management May 23, 2024
@mtnstar mtnstar merged commit bfab496 into master May 23, 2024
3 of 5 checks passed
@mtnstar mtnstar deleted the feature/sac_362_course_status branch May 23, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codez codez codez requested changes

@mtnstar mtnstar mtnstar requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EVENTS: Statuswechsel
3 participants
@TheWalkingLeek @codez @mtnstar