Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROLES: Neuanmeldungs-Rollen sollten kein Enddatum haben #650

Closed
wants to merge 4 commits into from
Closed

ROLES: Neuanmeldungs-Rollen sollten kein Enddatum haben #650

wants to merge 4 commits into from

Conversation

hunchr
Copy link
Contributor

@hunchr hunchr commented Jun 18, 2024 •
edited
Loading

Fixes: #535
Related: #178

@hunchr hunchr force-pushed the feature/535-remove-neuanmeldungen-enddate branch from 4eec9cc to 50e02f4 Compare June 18, 2024 14:19
@hunchr hunchr self-assigned this Jun 18, 2024
@hunchr hunchr force-pushed the feature/535-remove-neuanmeldungen-enddate branch from 261a65f to 60d3a10 Compare June 18, 2024 15:19
@hunchr hunchr requested a review from mtnstar June 18, 2024 16:11
@hunchr hunchr marked this pull request as ready for review June 18, 2024 16:11
@Largo Largo self-assigned this Jun 19, 2024
@hunchr hunchr requested review from Largo and removed request for mtnstar June 19, 2024 08:05
@hunchr hunchr force-pushed the feature/535-remove-neuanmeldungen-enddate branch 6 times, most recently from 2c19729 to a2ba8d5 Compare June 24, 2024 07:28
@hunchr hunchr force-pushed the feature/535-remove-neuanmeldungen-enddate branch 2 times, most recently from 18fc472 to 3992741 Compare June 24, 2024 13:26
@hunchr hunchr force-pushed the feature/535-remove-neuanmeldungen-enddate branch from 3992741 to a284ed4 Compare June 26, 2024 07:02
Largo
Largo approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@Largo Largo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Ich habe den Selbstregistrationsteil gemacht und nun gemergt :) 🚀
In Zukunft paar mehr Tests wäre gut.

app/models/group/sektions_mitglieder.rb Outdated Show resolved Hide resolved
app/models/group/sektions_mitglieder.rb Outdated Show resolved Hide resolved
spec/models/group/shared_examples_mitglied.rb Outdated Show resolved Hide resolved
spec/models/role_spec.rb Show resolved Hide resolved
@Largo Largo closed this Jun 26, 2024
@Largo Largo reopened this Jun 26, 2024
@Largo Largo closed this Jun 26, 2024
@Largo
Copy link
Contributor

Largo commented Jun 26, 2024

was successfully merged...

@hunchr hunchr deleted the feature/535-remove-neuanmeldungen-enddate branch June 27, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Largo Largo Largo approved these changes

Assignees

@hunchr hunchr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ROLES: Neuanmeldungs-Rollen sollten kein Enddatum haben
2 participants
@hunchr @Largo