Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

简化了一些branch #63

Merged
merged 16 commits into from
May 30, 2024
Merged

简化了一些branch #63

merged 16 commits into from
May 30, 2024

Conversation

KINGFIOX
Copy link

No description provided.

Origami404
Origami404 requested changes May 28, 2024
View reviewed changes
docs/unofficial-lab-env/comp-organ-lab2.md Outdated Show resolved Hide resolved
docs/unofficial-lab-env/comp-organ-lab2.md Outdated Show resolved Hide resolved
docs/unofficial-lab-env/comp-organ-lab2.md Outdated Show resolved Hide resolved
docs/unofficial-lab-env/comp-organ-lab2.md Outdated Show resolved Hide resolved
docs/unofficial-lab-env/comp-organ-lab2.md Outdated Show resolved Hide resolved
@shirok1
Copy link
Member

shirok1 commented May 29, 2024

刚刚发现这个 pr 是 hitszosa:dev/unofficial-lab-env-comp-organ-lab2 from KINGFIOX:dev/unofficial-lab-env-comp-organ-lab2 的，并不是合到主线，要不要先合了然后我们慢慢改 @Origami404

@KINGFIOX
Copy link
Author

等一下，我在改，先别合

@shirok1 shirok1 marked this pull request as draft May 29, 2024 13:54
@shirok1
Copy link
Member

shirok1 commented May 29, 2024

等你这边定稿

@KINGFIOX KINGFIOX marked this pull request as ready for review May 29, 2024 13:56
@SoraShu SoraShu requested a review from shirok1 May 30, 2024 11:06
kowyo
kowyo reviewed May 30, 2024
View reviewed changes
docs/unofficial-lab-env/comp-organ-lab2.md Outdated
# OpenSUSE
sudo zypper in -t pattern devel_C_C++
# Fedora
sudo dnf install build-essential git device-tree-compiler
```

如果配置环境过程中出现 "command not found." 可能是有依赖的工具没装，此时可以利用搜索引擎。

MacOS 需要安装 Homebrew 作为包管理器，请查阅 [Tuna Mirrors 的安装指南](https://mirrors.tuna.tsinghua.edu.cn/help/homebrew) 。
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MacOS is a typo, should use macOS.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

shirok1
shirok1 approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@shirok1 shirok1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我希望尽快合到仓库中的 dev 分支然后慢慢改

Origami404
Origami404 requested changes May 30, 2024
View reviewed changes
docs/unofficial-lab-env/comp-organ-lab2.md Outdated Show resolved Hide resolved
docs/unofficial-lab-env/comp-organ-lab2.md Outdated Show resolved Hide resolved
docs/unofficial-lab-env/comp-organ-lab2.md Outdated Show resolved Hide resolved
docs/unofficial-lab-env/comp-organ-lab2.md Outdated Show resolved Hide resolved
@KINGFIOX
MacOS -> macOS
51baf40 
    给 tcl 脚本链接
    删除配置 XServer 一节
    删除句式杂糅
Origami404
Origami404 approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@Origami404 Origami404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@shirok1 shirok1 merged commit ef6f906 into hitszosa:dev/unofficial-lab-env-comp-organ-lab2 May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kowyo kowyo kowyo left review comments

@Origami404 Origami404 Origami404 approved these changes

@shirok1 shirok1 shirok1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KINGFIOX @shirok1 @Origami404 @kowyo