Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SIGPIPE handling to the subscribe command #363

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Add SIGPIPE handling to the subscribe command #363

merged 2 commits into from
Oct 24, 2023

Conversation

LukasBrand
Copy link
Contributor

@LukasBrand LukasBrand self-assigned this Oct 11, 2023
@cla-bot cla-bot bot added the cla-signed label Oct 11, 2023
@gitseti
Copy link
Contributor

gitseti commented Oct 12, 2023 •
edited
Loading

Can we also assert the correct behavior in a simple single system test?

@LukasBrand LukasBrand force-pushed the feature/add-sigpipe-notification branch from d17eb2c to 05d80b7 Compare October 12, 2023 13:15
@LukasBrand
Copy link
Contributor Author

LukasBrand commented Oct 12, 2023 •
edited
Loading

Can we also assert the correct behavior in a simple single system test?

Unfortunately a system test is not trivial to setup for it and can be added later on.

@LukasBrand LukasBrand force-pushed the feature/add-sigpipe-notification branch from 05d80b7 to 124d735 Compare October 13, 2023 12:55
@LukasBrand LukasBrand merged commit 204aaa5 into master Oct 24, 2023
5 checks passed
@LukasBrand LukasBrand deleted the feature/add-sigpipe-notification branch October 24, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitseti gitseti gitseti approved these changes

Assignees

@LukasBrand LukasBrand

Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't pipe to head
2 participants
@LukasBrand @gitseti