Add image nodes try4 #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the example, the image is defined gby a url, when the image is defined by the url to a local file taint the canvas and the screenshot funtionality don't work. This commit add to 2_features.html the logic to add a image node, and add support to process the dataurl in the canves. The image is scaled to reduce the data size. ant.png image is from http://www.art4apps.org/ and is released under a Creative Commons Attribution-NonCommercial-ShareAlike license. (CC BY-NC-SA)
|
Prefect! I will merge this pull-request after more testing |
|
Any news about this? |
|
sorry, i'm late |
|
No problem, just to know. Thanks :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes points noted in the review of try3, and errors found in screenshot