Fix OAuth token retrieval #419
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks but I'm working on something similar already in my private tree, and will have something to share at some point in the future once I have some confidence in it. Appreciate the effort and the positive feedback! |
|
I actually prefer this PR as a model (simpler changes): https://github.com/Python-MyQ/Python-MyQ/pull/22/files I did some local testing and verified that will work, but I'm sure hjd's got it handled. |
|
I've pushed an update that addresses this - thanks again folks. |
|
This issue is locked to prevent necroposting on closed issues. Please create a new issue for related discussion, if needed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First let me say I have not tested this. Im not a TypeScript developer. Im just submitting this PR to try and learn and because as a user of your plugin I wanted to try and give back a tiny little bit. Im basing this off the comment on the HA plugin thread here: home-assistant/core#101763 (comment)
Thank you for all the work you have done on your plugins. I use them every day and I appreciate all the work you have done on them.