Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mol2D #207

Merged
merged 16 commits into from
Mar 21, 2024
Merged

Mol2D #207

merged 16 commits into from
Mar 21, 2024

Conversation

ralf-meyer
Copy link
Member

Adds the new Mol2D class including 3 different ways of constructing (from .mol, .mol2, and smiles) + the different versions of the molecular graph hash

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 93.81443% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 35.08%. Comparing base (3b66225) to head (8ded31e).
Report is 23 commits behind head on master.

Files Patch % Lines
molSimplify/Classes/mol2D.py 93.81% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
+ Coverage   34.72%   35.08%   +0.35%     
==========================================
  Files          90       91       +1     
  Lines       29998    30203     +205     
==========================================
+ Hits        10417    10596     +179     
- Misses      19581    19607      +26     
Flag Coverage Δ
unittests 35.08% <93.81%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/test_mol3D.py Fixed Show fixed Hide fixed
tests/test_mol3D.py Fixed Show fixed Hide fixed
@ralf-meyer ralf-meyer merged commit bc503a1 into master Mar 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant