Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework Get-SteamFriendList #75

Merged
merged 15 commits into from
Apr 19, 2024
Merged

Rework Get-SteamFriendList #75

merged 15 commits into from
Apr 19, 2024

Conversation

hjorslev
Copy link
Owner

@hjorslev hjorslev commented Mar 29, 2024 •
edited
Loading

Description

Resolves #66

  • Remove OutputFormat parameter
  • Change to non terminating error
  • Use Invoke-RestMethod to call the API
  • Output content as PSCustomObject

Type of change

  • 📖 [Docs]
  • 🪲 [Fix]
  • 🩹 [Patch]
  • ⚠️ [Security fix]
  • 🚀 [Feature]
  • 🌟 [Breaking change]

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added Pester tests that covers the added cmdlets

@hjorslev hjorslev linked an issue Mar 29, 2024 that may be closed by this pull request
Get-SteamFriendList should return a PSObject #66
Closed
@hjorslev hjorslev added the Category-Module Pertaining to the module's functionality itself. label Mar 29, 2024
@hjorslev hjorslev self-assigned this Mar 29, 2024
@hjorslev hjorslev added Category-Tests ✅ Pertaining to tests for the module functions. Issue-Enhancement ✨ Make it better! labels Mar 29, 2024
@hjorslev hjorslev mentioned this pull request Apr 1, 2024
Closed
@hjorslev hjorslev added Breaking 🌟 and removed Category-Tests ✅ Pertaining to tests for the module functions. labels Apr 2, 2024
@hjorslev hjorslev changed the title Refactor Get-SteamFriendList Rework Get-SteamFriendList Apr 14, 2024
@hjorslev hjorslev linked an issue Apr 16, 2024 that may be closed by this pull request
Pester Tests for Web API cmdlets #31
Closed
@hjorslev hjorslev merged commit 8c0a264 into master Apr 19, 2024
9 checks passed
@hjorslev hjorslev deleted the 66-get-steamfriendlist-should-return-a-psobject branch April 19, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hjorslev hjorslev

Labels
Breaking 🌟 Category-Module Pertaining to the module's functionality itself. Issue-Enhancement ✨ Make it better!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get-SteamFriendList should return a PSObject Pester Tests for Web API cmdlets
1 participant
@hjorslev