This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Do not try to remove a connection the slab twice #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A single event loop tick may contain multiple events for a token. If the connection is reset on the first event, subsequent events will still try to access that token/connection during the event loop tick. The strategy now is to mark a connection as reset and remove them only when the event loop tick is finished. See tokio-rs/mio#219 for more details. Fixes #1
hjr3
added a commit
that referenced
this pull request
Aug 22, 2015
Do not try to remove a connection the slab twice
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A single event loop tick may contain multiple events for a token. If the
connection is reset on the first event, subsequent events will still try
to access that token/connection during the event loop tick. The strategy
now is to mark a connection as reset and remove them only when the event
loop tick is finished.
See tokio-rs/mio#219 for more details.
Fixes #1