Fix for saving in rpm, deb and docker repo/registries #84

maniankara · 2017-03-25T14:00:52Z

Fix for #70.
Here are the some assumptions which needs to be modification:

package cloud: For now I have deployed it to my own fork repo maniankara/weldr which needs to be changed.
The package creation is done with docker only for all deb and x86_64 rpm. E.g. travis log, please comment.
Deployment to docker repository is missing.

- fpm (for package creation) and package-cloud (deploy package) gems to install - create weldr deb package with target opt/weldr - Added deploy details with maniankara account (for now) for debian/stretch

hjr3 · 2017-03-25T15:25:35Z

.travis.yml

+- mkdir opt
+- cp target/debug/weldr opt
+# Use the same docker image as much as possible
+- docker run -v "$(pwd):/src/" cdrx/fpm-centos:7 -s dir -t deb -v 0.1.0 -n weldr -C /src  opt/weldr


Should we replace the 0.1.0 version with $TRAVIS_TAG?

The user of docker here is fine with me. I originally thought it was going to be slow and was going to suggest doing something like if [ -n "$TRAVIS_TAG" ]; then something when tag set; fi but it looks quite fast.

However, now that I think about it we want to deploy the static binary version via cargo build --target x86_64-unknown-linux-musl --release. That is going to take a long time.

$TRAVIS_TAG

Oh, I missed that, actually I was using $(cargo pkgid| awk -F'#' {'print $2'}) in my sample branch.

if [ -n "$TRAVIS_TAG" ];

yes, this makes more sense

x86_64-unknown-linux-musl

yes, looks like (ref).
Should I use the gnu for now?

x86_64-unknown-linux-musl

yes, looks like (ref).
Should I use the gnu for now?

The musl build target works fine. See the DOCKER.md. If that is not working though, we can do a normal release cargo build --release and store that resulting binary in the deb/rpm package.

hjr3 · 2017-03-25T15:27:59Z

@maniankara This looks great! I made a comment about the after_success step. Also, I made you a collaborator on https://packagecloud.io/hjr3/weldr and https://hub.docker.com/r/hjr3/weldr/ . Let me know if you are able to access those.

maniankara · 2017-03-26T14:06:20Z

@hjr3 packagecloud looks better and I didnt get access to docker hub. My user account there is same as in here.

hjr3 · 2017-03-26T15:11:13Z

Hmm I added you as a collaborator for docker hub before:

What error are you seeing?

maniankara · 2017-03-27T17:51:12Z

There are no errors. I see only this (without edit icons, only general tabs etc.).

But I havent tried pushing to there, I will try and let you know.

hjr3 · 2017-03-28T01:06:26Z

@maniankara ya let me know. if that does not work, i will just create an organization and go from there. maybe i should create the org now? cc @yanns

yanns · 2017-03-28T09:48:56Z

@hjr3 if you find time, an organization would be nice.

hjr3 · 2017-03-28T14:10:56Z

@maniankara @yanns i created https://hub.docker.com/u/weldr/dashboard/ and added you both as admins

maniankara · 2017-03-28T16:43:15Z

Looks much better now !

- Use x86_64 tag for docker container

hjr3 · 2017-03-31T21:17:16Z

This looks great. I will change the packagecloud repo to an org and that looks to be it.

Is there anything else left to do?

maniankara · 2017-03-31T21:48:36Z

Yes. The binary is not statically linked. I can fix that quickly but, seems there might be support for x86_64 linux musl after all.

maniankara · 2017-03-31T21:50:42Z

Ah, I forgot the docker authentication part, the user/password needs to be somehow encrypted.

hjr3 · 2017-04-01T04:31:02Z

@maniankara I looked at https://github.com/rust-lang/rust/blob/master/.travis.yml and they do the musl stuff within docker as well. I know https://github.com/emk/rust-musl-builder is a pretty popular docker image that has rust and musl.

That also reminds me, we should only deploy from the stable build that has a tag.

We can encrypt private variables for the docker user/pass via the travis gem. Read https://docs.travis-ci.com/user/environment-variables/#Defining-encrypted-variables-in-.travis.yml for more details.

I looked and packagecloud.io does not have "organizations". I created a new weldr user and we should put the rpm/deb files at https://packagecloud.io/weldr/weldr . You are already a collaborator. I am removing https://packagecloud.io/hjr3/weldr

- also for docker builds

…testing purposes.

maniankara · 2017-04-01T16:05:27Z

@maniankara I looked at https://github.com/rust-lang/rust/blob/master/.travis.yml and they do the musl stuff within docker as well.

This is great. Now weldr is using that :)

That also reminds me, we should only deploy from the stable build that has a tag.

Yes, this has been the case, if you think something is missing, please feel free to point out :)

We can encrypt private variables for the docker user/pass via the travis gem. ...

Yes, I know about this and that's how the packagecloud thing works. However, I think you could add the credentials to dockerhub yourself for the weldr user, unless you transfer the credentials to me via something.

... packagecloud.io ...

Same, please suggest how to handle credentials here as well.

maniankara · 2017-04-05T18:49:25Z

ping @hjr3

hjr3 · 2017-04-07T15:03:26Z

@maniankara sorry for the delay! I was out of commission for a while and still catching up.

That also reminds me, we should only deploy from the stable build that has a tag.
Yes, this has been the case, if you think something is missing, please feel free to point out :)

I should have worded this better. The .travis.yml file will run on stable, beta and nightly versions of Rust. We should only deploy from the stable version of Rust. As is, I think we will deploy 3 times.

I think I understand what you mean with regards to credentials. I will push a commit shortly.

- add encrypted credentials - only build on stable rust

fixes

maniankara · 2017-04-08T21:30:59Z

@hjr3 Ah. Alright. Now I got the idea.
I have made a mess with the merge commit, etc. Hope its okay now.

maniankara · 2017-04-08T22:02:53Z

@hjr3 If you think we are done with this PR, I have recently learnt rust (starting with Tokio). What do you think would be a good bug to start with. I took a look at all of the open ones, some seemed to be old (not needed anymore?), linked (ordered) etc. Please suggest :)

hjr3 · 2017-04-10T15:19:29Z

Merged as 45dccf0

hjr3 · 2017-04-10T15:31:15Z

@maniankara thank you so much for helping with this PR.

If you want to work on something small, I think one of the items in #55 is an easy to place to start. That code is in https://github.com/hjr3/weldr/blob/master/src/proxy.rs in the form of simple functions. Maybe section 3.2.1 or 3.2.4?

hjr3 · 2017-04-13T01:53:31Z

@maniankara i landed a big PR today that unlocks a lot of progress. I added some more help wanted issues to the list.

anoop added 3 commits March 25, 2017 00:06

Added:

2ef55f7

- fpm (for package creation) and package-cloud (deploy package) gems to install - create weldr deb package with target opt/weldr - Added deploy details with maniankara account (for now) for debian/stretch

added on tags true to travis deploy

d022c13

use docker for building deb and rpm packages

5385fb7

hjr3 reviewed Mar 25, 2017

View reviewed changes

Build deb and rpm packages only on $TRAVIS_TAG.

cfe38f7

anoop added 2 commits March 28, 2017 19:53

added docker login and docker push

2d837e0

Move after_success to separate script

46b9392

maniankara changed the title ~~Fix for #70~~ Fix for saving in rpm, deb and docker repo/registries Mar 31, 2017

- Use debug (no targets) builds for now instead of x86_64-linux-musl.

b258147

- Use x86_64 tag for docker container

anoop added 2 commits April 1, 2017 18:30

- build x86_64 static musl

a9fee12

- also for docker builds

Revert the base container back to scratch. Was using Ubuntu for some …

f165831

…testing purposes.

Modified documentation for adding a server to the pool

07b1fa3

hjr3 and others added 3 commits April 7, 2017 09:06

fixes

58b2730

- add encrypted credentials - only build on stable rust

Merge pull request #1 from hjr3/builds

0ede2ca

fixes

Install fpm and package cloud gems only on stable channels

d3834cc

hjr3 added a commit that referenced this pull request Apr 10, 2017

Merge pull request #84 from maniankara/master

45dccf0

hjr3 closed this Apr 10, 2017

hjr3 mentioned this pull request Apr 10, 2017

Save in rpm, deb and docker repo/registries #70

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix for saving in rpm, deb and docker repo/registries #84

Fix for saving in rpm, deb and docker repo/registries #84

maniankara commented Mar 25, 2017

hjr3 Mar 25, 2017

maniankara Mar 26, 2017

hjr3 Mar 26, 2017

hjr3 commented Mar 25, 2017

maniankara commented Mar 26, 2017

hjr3 commented Mar 26, 2017

maniankara commented Mar 27, 2017

hjr3 commented Mar 28, 2017

yanns commented Mar 28, 2017

hjr3 commented Mar 28, 2017

maniankara commented Mar 28, 2017

hjr3 commented Mar 31, 2017

maniankara commented Mar 31, 2017

maniankara commented Mar 31, 2017

hjr3 commented Apr 1, 2017

maniankara commented Apr 1, 2017 •

edited

Loading

maniankara commented Apr 5, 2017

hjr3 commented Apr 7, 2017

maniankara commented Apr 8, 2017

maniankara commented Apr 8, 2017

hjr3 commented Apr 10, 2017

hjr3 commented Apr 10, 2017

hjr3 commented Apr 13, 2017

Fix for saving in rpm, deb and docker repo/registries #84

Fix for saving in rpm, deb and docker repo/registries #84

Conversation

maniankara commented Mar 25, 2017

hjr3 Mar 25, 2017

Choose a reason for hiding this comment

maniankara Mar 26, 2017

Choose a reason for hiding this comment

hjr3 Mar 26, 2017

Choose a reason for hiding this comment

hjr3 commented Mar 25, 2017

maniankara commented Mar 26, 2017

hjr3 commented Mar 26, 2017

maniankara commented Mar 27, 2017

hjr3 commented Mar 28, 2017

yanns commented Mar 28, 2017

hjr3 commented Mar 28, 2017

maniankara commented Mar 28, 2017

hjr3 commented Mar 31, 2017

maniankara commented Mar 31, 2017

maniankara commented Mar 31, 2017

hjr3 commented Apr 1, 2017

maniankara commented Apr 1, 2017 • edited Loading

maniankara commented Apr 5, 2017

hjr3 commented Apr 7, 2017

maniankara commented Apr 8, 2017

maniankara commented Apr 8, 2017

hjr3 commented Apr 10, 2017

hjr3 commented Apr 10, 2017

hjr3 commented Apr 13, 2017

maniankara commented Apr 1, 2017 •

edited

Loading