This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Use only a single thread #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we also remove the |
|
@yanns the test-server.rs code uses rustful. i added a note to fix or remove that so we can remove the rustful dependency. |
|
@hjr3 OK thx for the explanation. Then we can at least move the dependency to |
yanns
reviewed
Mar 25, 2017
| pub struct Pool { | ||
| inner: Arc<RwLock<inner::Pool>>, | ||
| inner: Rc<RefCell<InnerPool>>, |
|
@yanns yes, I will either move the rustful dep to dev-deps or remove the need for the dep prior to merge. |
|
one step closer! |
The proxy, management and health check streams are merged together so they can all run on the same thread. This removes the overhead of having multiple tokio Cores running at the same time and gets rid of dedicated threads for tasks that were not often used. Most importantly, it simplifies the Pool implementation to not require synchronization for reading servers out. I have also removed the dependency on rustful. Using rustful was requiring two different versions of hyper, which was causing some odd conflicts with dependencies.
This was referenced Apr 13, 2017
Closed
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is testing much faster than using multiple threads (due to the lack of mutex lock contention for the pool). I was also able to remove rustful from the management API scope so we only have one version of hyper.
I have a few open items to fix: