Feature/custom range map #118
Conversation
- provide 4 range options 100m, 200m, 500m, 1km to users
accept searchRange prop in getSelectedRoutes and set 1000 as default
this is planned to be used in enable user setting search range
There was a problem hiding this comment.
IMO it looks better with a bit more margin in front of "米".
Also, I tested this on a Pixel 4a, and dragging the slider is still painfully slow. Did a bit of profiling but looks like React is not the culprit (only taking 2ms per frame), most likely leaflet just can't update that fast.
I know it would be a bit more complicated, but only update the radius of the Circle after a bit of delay (or after mouse/finger release) would greatly improve performance.
Otherwise it seems to work okay 👍
| @@ -422,3 +692,41 @@ const getSelectedRoutes = ({ | |||
| ), | |||
| }; | |||
| }; | |||
|
|
|||
| const ListItem = styled("li")(({ theme }) => ({ | |||
| margin: theme.spacing(0.5), | |||
There was a problem hiding this comment.
| margin: theme.spacing(0.5), | |
| margin: `${theme.spacing(0.5)} ${theme.spacing(1)}`, |
|
Frankly speaking, your PR has merged many commits other than the feature of "custom range map". It is highly not recommended as other PRs are not all accepted, and this PR has even removed the |
Demo: https://hk-independent-bus-eta.web.app/
Existing bug:
If mobile is turned landscape when the dialog is opened, the map has no space to show and the center will be off.
(possibly need to use css to assign element style when the mobile is in landscape, related to this PR)