Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LipSync doesn't work #3

Closed
iRi-E opened this issue Apr 21, 2011 · 0 comments
Closed

LipSync doesn't work #3

iRi-E opened this issue Apr 21, 2011 · 0 comments

Comments

@iRi-E
Copy link

iRi-E commented Apr 21, 2011

The LipSync feature doesn't work at all in my system.

I investigated this problem and found that the bug is in QMALipSyncLoader::load().

In this function, expression names and phone names are copied from .lip file as follows:

int len = data.length();
char *s = new char[len];
memcpy(s, data.constData(), len);

but these copies of the strings don't have information of their lengths, so MotionController::setup() and LipSync::createMotion() cannot compare correctly the face names and the phone names, respectively.

I modified the codes as follows to copy '\0' at the ends of the names:

int len = data.length();
char *s = new char[len + 1];
memcpy(s, data.constData(), len + 1);

and confirmed the LipSync works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant