Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named args #174

Merged
merged 58 commits into from
Sep 29, 2023
Merged

Named args #174

merged 58 commits into from
Sep 29, 2023

Conversation

mbroughani81
Copy link
Contributor

  • rename the variables used in desugaring.
  • delete unnecessary logs
  • add test

.vscode/settings.json Show resolved Hide resolved
shared/src/main/scala/mlscript/NuTypeDefs.scala Outdated Show resolved Hide resolved
shared/src/main/scala/mlscript/Typer.scala Outdated Show resolved Hide resolved
shared/src/main/scala/mlscript/Typer.scala Outdated Show resolved Hide resolved
shared/src/main/scala/mlscript/Typer.scala Outdated Show resolved Hide resolved
shared/src/test/diff/wander/Wander.mls Outdated Show resolved Hide resolved
@NeilKleistGao
Copy link
Member

Before making a formal PR(i.e., non-draft), please:

  • read the contribution guide
  • make sure your code passes all regression tests
  • remove all compilation warning messages and unnecessary debug information

shared/src/main/scala/mlscript/Typer.scala Outdated Show resolved Hide resolved
shared/src/main/scala/mlscript/Typer.scala Outdated Show resolved Hide resolved
shared/src/main/scala/mlscript/Typer.scala Outdated Show resolved Hide resolved
shared/src/main/scala/mlscript/Typer.scala Outdated Show resolved Hide resolved
@mbroughani81 mbroughani81 deleted the named-args branch August 25, 2023 10:06
Copy link
Contributor

@LPTK LPTK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually there are still a bunch of things to improve before we can merge this.

You need to understand that err reports an error message to the programmer. Doing things like err("match error", f.toLoc) makes zero sense.

shared/src/main/scala/mlscript/Typer.scala Outdated Show resolved Hide resolved
shared/src/main/scala/mlscript/Typer.scala Outdated Show resolved Hide resolved
shared/src/main/scala/mlscript/Typer.scala Outdated Show resolved Hide resolved
shared/src/main/scala/mlscript/Typer.scala Outdated Show resolved Hide resolved
shared/src/main/scala/mlscript/Typer.scala Outdated Show resolved Hide resolved
shared/src/main/scala/mlscript/Typer.scala Outdated Show resolved Hide resolved
shared/src/main/scala/mlscript/Typer.scala Outdated Show resolved Hide resolved
shared/src/main/scala/mlscript/Typer.scala Outdated Show resolved Hide resolved
shared/src/main/scala/mlscript/Typer.scala Outdated Show resolved Hide resolved
shared/src/main/scala/mlscript/Typer.scala Outdated Show resolved Hide resolved
@LPTK
Copy link
Contributor

LPTK commented Sep 26, 2023

I noticed that your latest commits removed some test cases, for example 84995d0. There are already very few tests, so please do not make it worse by reducing the coverage further! ;^)

Copy link
Contributor

@LPTK LPTK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I think we can merge now. Please address the remaining comments and I'll make the squash-merge later.

shared/src/main/scala/mlscript/Typer.scala Outdated Show resolved Hide resolved
shared/src/main/scala/mlscript/Typer.scala Outdated Show resolved Hide resolved
@LPTK LPTK merged commit 08dee51 into hkust-taco:new-definition-typing Sep 29, 2023
1 check passed
fo5for added a commit to fo5for/mlscript that referenced this pull request Mar 24, 2024
fo5for added a commit to fo5for/mlscript that referenced this pull request Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants