Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduced IPA support #76

Closed
wants to merge 7 commits into from
Closed

Introduced IPA support #76

wants to merge 7 commits into from

Conversation

jkiddo
Copy link
Collaborator

@jkiddo jkiddo commented Sep 17, 2022

No description provided.

@jkiddo jkiddo requested a review from jacand April 24, 2023 19:04
@jkiddo jkiddo added this to the 2.3.0 milestone Apr 24, 2023
jacand
jacand reviewed Apr 25, 2023
View reviewed changes
sushi-config.yaml Outdated Show resolved Hide resolved
input/fsh/DkCorePatient-Profile.fsh Outdated Show resolved Hide resolved
@jkiddo
Update dep of IPA
ab9d9a6
@jkiddo
Adjusted to 1.0.0
1ebc509
@jkiddo
Merge branch 'master' into feature/ipa-support
03dafab 
# Conflicts:
#	input/fsh/DkCorePatient-Profile.fsh
#	input/fsh/DkCorePractioner-Profile.fsh
#	input/fsh/confidential.fsh
@jkiddo
Removed merge files
3585cae
@jkiddo jkiddo changed the base branch from master to 2.3.0 April 30, 2023 21:21
@jkiddo jkiddo marked this pull request as ready for review April 30, 2023 21:21
@jkiddo jkiddo modified the milestones: 2.3.0, 3.1.0 Oct 24, 2023
@jacand
Copy link
Collaborator

jacand commented Dec 8, 2023

The PR is targeting the 2.3.0 branch but you have just merged with master which is now at 3.0.0. I believe you want to re-target this PR

The changes all look fine to me. 4 thoughts, though:

  1. Did we decide in the FHIR SIG / HL7-DK to inherit from the IPA profiles rather than the base FHIR resources? If not, we should bring that question up for a formal decision/vote.
  2. In 3.1.0 the BasicParameter / basic-observation is introduced. I think we should consider aligning that one with IPAObservation. As we haven't got multiple inheritance, some "manual" work would be necessary
  3. All these IPA dependencies should also be reflected in the introductions to each resource profile, and I think we should have a general introduction to IPA and how we use it "somewhere".
  4. We are starting to support FHIR R5 for trial use. Adding IPA would be a good case for "testing" our new process for keeping the revisions aligned. So before merging this PR, I think a matching PR for the R5 branch should be created - cherry picking the changes to that branch as well.

@jkiddo jkiddo changed the base branch from 2.3.0 to v.3.1.0-rc1 December 8, 2023 17:30
Base automatically changed from v.3.1.0-rc1 to master January 6, 2024 18:55
@jkiddo
Merge branch 'master' into feature/ipa-support
13ce41b 
# Conflicts:
#	input/fsh/DkCorePatient.fsh
@jkiddo jkiddo changed the base branch from master to 3.3.0 May 12, 2024 09:45
@jkiddo jkiddo closed this May 12, 2024
@jkiddo jkiddo deleted the feature/ipa-support branch May 12, 2024 09:48
@jkiddo jkiddo mentioned this pull request May 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacand jacand jacand left review comments

@tmsMedcom tmsMedcom Awaiting requested review from tmsMedcom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jkiddo @jacand