Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Architecture & Inference Pipeline #1

Open
lateralus69 opened this issue May 21, 2019 · 2 comments
Open

Wrong Architecture & Inference Pipeline #1

lateralus69 opened this issue May 21, 2019 · 2 comments

Comments

@lateralus69
Copy link

lateralus69 commented May 21, 2019

In conv2d block function the x coming out from activation function after first layer should go in the second convolution layer instead of original input tensor.
The re-written code for second layer in the function should be

# second layer
x = Conv2D(filters = n_filters, kernel_size = (kernel_size, kernel_size),\
          kernel_initializer = 'he_normal', padding = 'same')(x) #this was the change
if batchnorm:
    x = BatchNormalization()(x)
x = Activation('relu')(x)

return x`

Also in the inference pipeline you are using using contours from ground truth of validation set and plotting them on the predicitions of validation set which makes so sense.

That was a noob way to show good predictions.

@hlamba28
Copy link
Owner

Hi @lateralus69 ,

Thanks for pointing out the mistakes.
I will try to correct them as I get sometime.

By the way these are just practice projects which I have done for self learning and I completely agree that there can be some mistakes in them. I do not have any intention to show great predictions.

Hope you are doing well.
Thanks

@hlamba28
Copy link
Owner

Also, I agree for your first point, however there is no problem with the inference pipeline. The contour (boundary) has to be from the ground truth to show how much the predictions overlap with the real boundary. Clearly the validation set predictions are not 100% correct.

hlamba28 pushed a commit that referenced this issue Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants