Do nothing if migrate! is called on a test DB when que-testing is present #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlascelles
force-pushed
the
do-nothing-if-que-testing-is-present
branch
from
b34c9d1
to
2df1fdf
Compare
|
This is to cater for #37 |
hlascelles
force-pushed
the
do-nothing-if-que-testing-is-present
branch
from
eee6430
to
bec689b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When que-testing is present, calls to Que.execute do nothing and return an empty array. Thus, trying to migrate a test database will always fail. It is safer to do nothing and not create the que-scheduler tables. This follows the logic of que, which does not create its tables either.