Added travis checks #57
Conversation
README.md
Outdated
| @@ -1,6 +1,8 @@ | |||
| WordPress Plugin Template | |||
| ========================= | |||
|
|
|||
| [](https://travis-ci.org/carl-alberto/WordPress-Plugin-Template) | |||
There was a problem hiding this comment.
You seem to have added your own travis link here.
There was a problem hiding this comment.
Thanks for pointing that our, still new to WPCS and Travis :), updated my PR
codesniffer.ruleset.xml
Outdated
| <!-- See https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/blob/develop/WordPress-Core/ruleset.xml --> | ||
|
|
||
| <!-- Set a description for this ruleset. --> | ||
| <description>A custom set of code standard rules to check for WordPress themes.</description> |
There was a problem hiding this comment.
You may want to customize this more or at least change theme to plugin. I would also give credit where it is due. This seems to be taken from _s
There was a problem hiding this comment.
Thanks for pointing that our, still new to WPCS and Travis :), updated my PR
There was a problem hiding this comment.
Could you also mention where you copied the files from as that is normally a requirement of open source licensing?
There was a problem hiding this comment.
Sure, updated PR to reflect the source of the ruleset. Thanks for the guidance!
-updated travisci to point to hlashbrooke
…ce of the configuration
|
@grappler are you happy with the latest updates to this? |
|
@jonathanbossenger A lot has changed in the last years. I am not sure if the PHPCS is still working correctly in this travis file. A few updates that could be made are:
|
|
Thanks. @carl-alberto if you have some free time, perhaps you can look at implementing these changes? Other wise I will try to do so over the course of the next few weeks. |
|
@jonathanbossenger thanks for the bump, I'll try to revisit this this weekend :) |
|
Thanks @carl-alberto no rush if you don't. |
|
@jonathanbossenger My branch carl-alberto:feature/wpcs-compliant is way outdated, when doing PR's do we still branch from master or develop? |
|
@carl-alberto thanks for asking, please submit all PR's against |
|
Closing this because this was all completed with #75 |
No description provided.