Skip to content
This repository has been archived by the owner on Jul 18, 2023. It is now read-only.

WP CS compliant and Travis integration #56

Closed
carl-alberto opened this issue Feb 5, 2017 · 5 comments
Closed

WP CS compliant and Travis integration #56

carl-alberto opened this issue Feb 5, 2017 · 5 comments

Comments

@carl-alberto
Copy link
Collaborator

Hi Hugh,

I really like your project and this helped me a lot in building plugins. I was looking into making it more WP CS compliant https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards and put some Travis checks. I hope your not too busy maintaining this project, maybe I can help out on the maintenance?

@hlashbrooke
Copy link
Owner

Making this more standards compliant would be great! It's been a while since I actually looked at this code, but I'm fairly sure it is mostly WP CS compliant already. That being said, if there's any way to improve it on that front then I'm happy to accept PRs :)

@carl-alberto
Copy link
Collaborator Author

Awesome, I could get started adding with a travis check with phpcs, jshint and jscs #57

@carl-alberto
Copy link
Collaborator Author

@jonathanbossenger Referencing the new PR against this issue for our reference #75

Thanks!

@carl-alberto
Copy link
Collaborator Author

We can also address the PR here: #57

I'll close this pending PR #63 in favor of the new PR that I have above

@jonathanbossenger
Copy link
Collaborator

Merged #76 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants