Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change class to typename in typedef #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

change class to typename in typedef #10

wants to merge 1 commit into from

Conversation

jmitrevs
Copy link

@jmitrevs jmitrevs commented Jul 6, 2022

I believe this change is needed for strict C++ compatibility, to identify to treat a value as a typenane. I think one needs to use typename in this case and not class. Clang on the Mac complains without this change, though I only tested it for ac_pow_pwl.

@jmitrevs
Copy link
Author

jmitrevs commented Jul 6, 2022

I noticed that some (but not all, I think) of these changes are in #1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jmitrevs