Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only compare bytes that were read into the buffers in this round #1

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

ghhenry
Copy link
Contributor

@ghhenry ghhenry commented Sep 26, 2021

While the current version is correct (because the buffers were equal during the previous round), it is not necessary to compare the extra bytes.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1274743751

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.8%) to 81.25%

Totals Coverage Status
Change from base Build 466615514: -0.8%
Covered Lines: 52
Relevant Lines: 64

💛 - Coveralls

@hlubek
Copy link
Owner

hlubek commented Sep 27, 2021

Thanks for your contribution and the optimization! Indeed we don't need to compare the full buffers.

@hlubek hlubek merged commit 8f5e69a into hlubek:main Sep 27, 2021
@coveralls
Copy link

coveralls commented Sep 19, 2024

Pull Request Test Coverage Report for Build 1274743751

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.8%) to 81.25%

Totals Coverage Status
Change from base Build 466615514: -0.8%
Covered Lines: 52
Relevant Lines: 64

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants