Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ItemEncrypted plugin to support GPG 2.1 #2464

Closed
wants to merge 6 commits into from

Conversation

realchrisolin
Copy link

This PR is a work-in-progress designed to resolve #2463. I don't know if I'll ever be able to finish it, but it should give someone more familiar with C++ and Qt that's trying to fix this issue a place to start and build on.

@hluk
Copy link
Owner

hluk commented Sep 19, 2023

Can you explain how the fix should work? Should this just skip the --import and --export command if the gpg version is 2.1 or above?

BTW, on Linux I get version 2.4.0 and all works well:

❯ gpg --version
gpg (GnuPG) 2.4.0
libgcrypt 1.10.2-unknown
Copyright (C) 2021 Free Software Foundation, Inc.
...

I guess the check would need to include the Copyright line too.

@hluk
Copy link
Owner

hluk commented Sep 19, 2023

Actually, I think I understand the situation from your old comment (#1208 (comment)). Let me try implementing the fix.

@hluk
Copy link
Owner

hluk commented Sep 20, 2023

Should be fixed - see #1208 (comment).

Thanks for the help! 🙏

@hluk hluk closed this Sep 20, 2023
@realchrisolin realchrisolin deleted the issue2463 branch November 7, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite ItemEncrypted plugin to support modern versions of GPG
2 participants