Experiments not sending data #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
vtsaplin
reviewed
Jan 16, 2024
solutions/scripts/scripts.js
Outdated
| @@ -37,7 +43,10 @@ window.hlx.plugins.add('rum-conversion', { | |||
| window.hlx.plugins.add('experimentation', { | |||
| condition: () => getMetadata('experiment'), | |||
| options: { | |||
| audiences: AUDIENCES, | |||
There was a problem hiding this comment.
@andreibogdan I wonder if "audiences" param is necessary. It might introduce an unintended dimension to the experiment, and we also don't include it in the report.
There was a problem hiding this comment.
I added this for testing purposes. I will remove it.
vtsaplin
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #436
Test URLs: