Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blog pages): accessibility, tags #211

Merged
merged 5 commits into from
Jun 2, 2023
Merged

fix(blog pages): accessibility, tags #211

merged 5 commits into from
Jun 2, 2023

Conversation

helms-charity
Copy link
Collaborator

@helms-charity helms-charity commented Jun 1, 2023

This fixes styling for the subheading in ticket #172 .
It also has CSS fixes to allow for all the H1 + H2 changes I have made to the blog changes in order to increase accessibility score.

Also this puts tags ABOVE picture + author-bio, instead of BELOW the H1, since we may or may not have that lede paragraph.

Also has a quick fix for teaser-list font bug I introduced...

Issue

Fix #210

Test URLs

Description

CSS was added as seen via https://www.figma.com/file/5N1U4VkQfWxw72KLGFwHcj/Blog-article-additions?type=design&node-id=3-167&t=D5KcIKRLZmhFFsdM-0 .

@aem-code-sync
Copy link

aem-code-sync bot commented Jun 1, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Jun 1, 2023

Page Scores Audits Google
/blog/test-article-1 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@helms-charity helms-charity marked this pull request as draft June 1, 2023 16:12
Copy link

@proeung proeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@helms-charity The subhead is rendering, however, styles are missing. See below for suggestions or I'm happy to open a follow up PR to address the styling once these changes are merged down.

/* text max contianer */
--text-max-container: 648px;

p.lede {
  font-size: var(--font-size-18);
  max-width: var(--text-max-container);
}

/* Article subhead for desktop*/
p.lede {
    font-size: var(--font-size-24);
 }

@aem-code-sync
Copy link

aem-code-sync bot commented Jun 2, 2023

Page Scores Audits Google
/blog/test-article-1 Lighthouse returned error: Something went wrong. PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Jun 2, 2023

@aem-code-sync
Copy link

aem-code-sync bot commented Jun 2, 2023

@helms-charity helms-charity changed the title add js classes only fix(blog pages): accessibility, tags Jun 2, 2023
@helms-charity helms-charity marked this pull request as ready for review June 2, 2023 17:02
@helms-charity helms-charity merged commit 2658880 into main Jun 2, 2023
@helms-charity helms-charity deleted the 210-seoblogs branch June 2, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lighthouse accessibility for blog article headings
2 participants