You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes styling for the subheading in ticket #172 .
It also has CSS fixes to allow for all the H1 + H2 changes I have made to the blog changes in order to increase accessibility score.
Also this puts tags ABOVE picture + author-bio, instead of BELOW the H1, since we may or may not have that lede paragraph.
Also has a quick fix for teaser-list font bug I introduced...
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.
The reason will be displayed to describe this comment to others. Learn more.
@helms-charity The subhead is rendering, however, styles are missing. See below for suggestions or I'm happy to open a follow up PR to address the styling once these changes are merged down.
/* text max contianer */--text-max-container:648px;
p.lede {
font-size:var(--font-size-18);
max-width:var(--text-max-container);
}
/* Article subhead for desktop*/p.lede {
font-size:var(--font-size-24);
}
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes styling for the subheading in ticket #172 .
It also has CSS fixes to allow for all the H1 + H2 changes I have made to the blog changes in order to increase accessibility score.
Also this puts tags ABOVE picture + author-bio, instead of BELOW the H1, since we may or may not have that lede paragraph.
Also has a quick fix for teaser-list font bug I introduced...
Issue
Fix #210
Test URLs
Description
CSS was added as seen via https://www.figma.com/file/5N1U4VkQfWxw72KLGFwHcj/Blog-article-additions?type=design&node-id=3-167&t=D5KcIKRLZmhFFsdM-0 .