Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(back-to-top): remove back to top in favor of Drift #310

Merged
merged 4 commits into from
Aug 18, 2023

Conversation

proeung
Copy link

@proeung proeung commented Aug 7, 2023

Issue

Fixes - https://jira.sdlc.merative.com/browse/MERATIVE-815

Description

Removed

  • This PR removes the Back to Top button functionality so that we can use the bottom right hand corner for the Drift Chatbot Widget.

Design Specs

  • Figma Link - N/A

Test URLs

Testing Instruction

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 7, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 7, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@proeung proeung added the Needs Stakeholders sign off Merative team sign off label Aug 7, 2023
@keith-kaplan
Copy link
Collaborator

Here is the preview URL you can use to test Drift. https://feat-drift-remove-back-to-top--merative2--proeung.hlx.page/#bot_test-5086233-t9fx4CHq

I'll adjust the spacing so there's no offset.

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 7, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@proeung
Copy link
Author

proeung commented Aug 7, 2023

@keith-kaplan Looks good! I'm going to review this on our Merative.com design call tomorrow and see if folks have any feedback on this. In the meantime, I'll leave this PR open.

Screenshot 2023-08-07 at 1 58 42 PM
Screenshot 2023-08-07 at 1 58 48 PM

@aavilamer
Copy link

@proeung Let's update the use of the logo in the center. We should just use the default chat icon like pure storage.
MicrosoftTeams-image (78)

@proeung
Copy link
Author

proeung commented Aug 8, 2023

@proeung Let's update the use of the logo in the center. We should just use the default chat icon like pure storage.

@aavilamer Yep, we can upload a new custom icon for this avatar. I looked through our Icon library within our design system (see link), but didn't find a chat icon that works for this context.

Is there a style or SVG that you have in mind? Here are some options that we can look at.

@aavilamer
Copy link

aavilamer commented Aug 8, 2023 via email

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 9, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@proeung
Copy link
Author

proeung commented Aug 9, 2023

@aavilamer Here's the latest preview using the icon that we discussed. https://feat-drift-remove-back-to-top--merative2--proeung.hlx.page/#bot_test-5086233-t9fx4CHq

Screenshot 2023-08-09 at 1 28 47 PM
Screenshot 2023-08-09 at 1 28 52 PM

@aavilamer
Copy link

@keith-kaplan where did the name land? Bot could be MerativeChat, MerativeConnect, MeraTalk, Product Advisor...throwing a few themes out there.

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 10, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@proeung
Copy link
Author

proeung commented Aug 10, 2023

@keith-kaplan where did the name land? Bot could be MerativeChat, MerativeConnect, MeraTalk, Product Advisor...throwing a few themes out there.

@aavilamer Personally, I like MerativeChat, but defer to you and @keith-kaplan on what to name the bot.

Also, @keith-kaplan do we have a date on when we'll be switching on Drift for the merative.com domain name? I think can merge this PR to remove the "Back to Top" button if we're ready to roll this out unless we want to wait until this button is removed on AEM (see - https://jira.sdlc.merative.com/browse/MERATIVE-814) as well.

@keith-kaplan
Copy link
Collaborator

Still confirming the name, but we're thinking Merative Bot. For the merge. This is not going live until 2nd week of Sept so I think we can do this in a few weeks.

@proeung proeung added the On-Hold Work is on-hold until proper sign off label Aug 10, 2023
@aem-code-sync
Copy link

aem-code-sync bot commented Aug 14, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Collaborator

@keith-kaplan keith-kaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@proeung proeung merged commit 8a6c84f into hlxsites:main Aug 18, 2023
2 checks passed
@proeung proeung removed Needs Stakeholders sign off Merative team sign off On-Hold Work is on-hold until proper sign off labels Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants