Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIV-14062 action caption on APPLICATION_ADD_PAYMENT status #4208

Merged

Conversation

david-jeronimo
Copy link
Contributor

@david-jeronimo david-jeronimo commented Jul 17, 2024

Before creating a pull request make sure that:

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:

JIRA link

https://tools.hmcts.net/jira/browse/CIV-14062

Change description

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

manish14836
manish14836 previously approved these changes Jul 17, 2024
@@ -2794,7 +2794,7 @@
"STATES": {
"PENDING_APPLICATION_ISSUED": "General Application Issue Pending",
"AWAITING_RESPONDENT_RESPONSE": "Awaiting Respondent Response",
"APPLICATION_ADD_PAYMENT": "Application Additional Payment",
"APPLICATION_ADD_PAYMENT": "Pay the additional application fee",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change required in cy.json as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these fields are still in English in cy.json

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both files should be consistent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Both changed now. Thanks

paul-pearson
paul-pearson previously approved these changes Jul 17, 2024
@david-jeronimo david-jeronimo force-pushed the feat/CIV-14062_view_application_judge_changed_to_withNotice branch from 4c36fa0 to 7da716d Compare July 17, 2024 09:18
@sankhajuria sankhajuria merged commit 4fa83dd into master Jul 23, 2024
5 checks passed
@sankhajuria sankhajuria deleted the feat/CIV-14062_view_application_judge_changed_to_withNotice branch July 23, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants