Refactored code and added tests

Author: sabahirfan

helpers/shouldRejectErrorResponse.js

@@ -0,0 +1,11 @@
+/**
+ * Checks if the options.simple is set to use default.
+ *
+ * @param options a request.options object
+ * @return boolean true if options.simple is set to use default value
+ */
+function shouldRejectErrorResponse (options) {
+  return (options.simple === undefined || options.simple === true);
+}
+
+module.exports = shouldRejectErrorResponse;

index.js

@@ -11,7 +11,8 @@ var extend = require('extend');
 var when = require('when');
 var request = require('request');
 var RetryStrategies = require('./strategies');
-var isErrorResponse = require('./helpers/isErrorResponse')
+var isErrorResponse = require('./helpers/isErrorResponse');
+var shouldRejectErrorResponse = require('./helpers/shouldRejectErrorResponse');
 var _ = require('lodash');
 var { StatusCodeError } = require('request-promise-core/errors');
 
@@ -111,7 +112,7 @@ function Request(url, options, f, retryConfig) {
       return this._reject(err);
     }
 
-    if ((options.simple === undefined || options.simple === true) && isErrorResponse(response)) {
+    if (shouldRejectErrorResponse(options) && isErrorResponse(response)) {
       return this._reject(new StatusCodeError(response.statusCode, body, this.options, response));
     }
 

test/helpers/shouldRejectErrorResponse.test.js

@@ -0,0 +1,16 @@
+'use strict'
+
+const shouldRejectErrorResponse = require('../../helpers/shouldRejectErrorResponse');
+const expect = require('chai').expect;
+
+describe('shouldRejectErrorResponse', function () {
+  [{ simple: true }, {}].forEach(options => {
+    it(`should return true for ${options.simple} simple`, function () {
+      expect(shouldRejectErrorResponse({ options: options })).to.equal(true);
+    });
+  });
+
+  it('should return false for options.simple false', function () {
+    expect(shouldRejectErrorResponse({ simple: false })).to.equal(false);
+  });
+});