Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding previousPath to local so the template back button can point to it #136

Closed
wants to merge 2 commits into from

Conversation

barbaracassani
Copy link
Contributor

The story says that the back button needs to work without js.

Therefore it must be a link: this little hack make the templates able to access previousPath if it's possible to determine it.

@bendiggle I am sure I am neglecting one or more arcane edge cases, please do advise :)

Copy link

@chrisgrimble chrisgrimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bendiggle bendiggle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like I mentioned in slack. This won't work and will end u p being a loop 😭

@michaeldfallen
Copy link
Contributor

Other services rely on the fact that the browser back button still works and hide the back link if javascript is not available.

See https://www.gov.uk/register-to-vote for an example.

Copy link
Contributor

@dtaylor7 dtaylor7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with comments above, i think we just hide back button if no JS

@dtaylor7
Copy link
Contributor

closing due to inactivity

@dtaylor7 dtaylor7 closed this Oct 22, 2018
@mounikahmcts mounikahmcts deleted the SSCS-3597-back-button branch November 8, 2018 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants