-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add non-postcode validation and persistence #1099
Merged
connorpgpmcelroy
merged 7 commits into
feature/Register-Other-Org-Sprint-31.4
from
feature/EUI-8756-is-uk-address-func
Sep 21, 2023
Merged
Add non-postcode validation and persistence #1099
connorpgpmcelroy
merged 7 commits into
feature/Register-Other-Org-Sprint-31.4
from
feature/EUI-8756-is-uk-address-func
Sep 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-31.4' into feature/EUI-8756-is-uk-address-func
DavidJayakumar
suggested changes
Sep 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@connorpgpmcelroy Found a typo in model, requires changing it all other places referred
johnbenjamin-hmcts
suggested changes
Sep 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@connorpgpmcelroy - few changes requested.
src/register-org/containers/registered-address/registered-address.component.html
Outdated
Show resolved
Hide resolved
src/register-org/containers/registered-address/registered-address.component.ts
Outdated
Show resolved
Hide resolved
src/register-org/containers/registered-address/registered-address.component.ts
Outdated
Show resolved
Hide resolved
src/register-org/containers/registered-address/registered-address.component.html
Outdated
Show resolved
Hide resolved
johnbenjamin-hmcts
approved these changes
Sep 18, 2023
DavidJayakumar
approved these changes
Sep 18, 2023
…I-8756-is-uk-address-func
connorpgpmcelroy
merged commit Sep 21, 2023
b644586
into
feature/Register-Other-Org-Sprint-31.4
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/EUI-8756
Change description
Validity and persistence for non-postcode address journey
Does this PR introduce a breaking change? (check one with "x")