Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ex UI 1782 rework case role allocation screens to allow allocate to me #3718

Conversation

OgunyemiO
Copy link
Contributor

Jira link (if applicable)

https://tools.hmcts.net/jira/browse/EXUI-1782

Change description

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

@OgunyemiO OgunyemiO added the enable_keep_helm enable_keep_helm label Jun 7, 2024
Copy link
Contributor

@connorpgpmcelroy connorpgpmcelroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@andywilkinshmcts andywilkinshmcts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would personally not have change the name of the enumeration item, I would just have changed it's value, but what you've done is basically fine. You do need to fix the tests, rather than just disabling them

…se-role-allocation-screens-to-allow-allocate-to-me' into EXUI-1782-Rework-case-role-allocation-screens-to-allow-allocate-to-me
RiteshHMCTS
RiteshHMCTS previously approved these changes Jun 17, 2024
olusegz07
olusegz07 previously approved these changes Jun 17, 2024
Copy link
Contributor

@andywilkinshmcts andywilkinshmcts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing now?

@RiteshHMCTS RiteshHMCTS changed the base branch from master to mc-srt-release-22-07-24 July 22, 2024 10:15
@RiteshHMCTS RiteshHMCTS merged commit b79bee0 into mc-srt-release-22-07-24 Jul 22, 2024
1 check was pending
@RiteshHMCTS RiteshHMCTS deleted the EXUI-1782-Rework-case-role-allocation-screens-to-allow-allocate-to-me branch July 22, 2024 10:15
RiteshHMCTS added a commit that referenced this pull request Jul 25, 2024
* Ex UI 1782 rework case role allocation screens to allow allocate to me (#3718)

* changes Reserve to me label to Allocate to me

* role category filtering removed from the choose-role component

* commented unrelated unit tests

* comment out unrelated unit tests

* yarn audit

* proposed fix for functional test failure

* yarn audit

* Unit tests fix based on PR review

* pipeline build failure fixes

---------

Co-authored-by: RiteshHMCTS <74713687+RiteshHMCTS@users.noreply.github.com>
Co-authored-by: Ritesh Dsouza <ritesh.dsouza@HMCTS.net>

* Add fix for caseworker names not appearing in task lists (#3751)

* Add fix for caseworker names not appearing in task lists

* Updating Terraform Formatting

* Update yarn-audit-known-issues

* Update yarn-audit-known-issues

---------

Co-authored-by: 54687 <61242337+hmcts-jenkins-j-to-z[bot]@users.noreply.github.com>
Co-authored-by: RiteshHMCTS <74713687+RiteshHMCTS@users.noreply.github.com>

* Bug/e UI 2028 tasks not being unassigned (#3794)

* Add the new pre-sign-in caseworker calls

* Fix lint issues

* Create caseWorkerUserDataCacheService.spec.ts

* Fix linting issues

* Attempt to fix functional tests

* Fix functional tests

* Update caseWorkerUserDataCacheService.ts

* Update caseWorkerUserDataCacheService.ts

---------

Co-authored-by: Andy Wilkins <49269487+andywilkinshmcts@users.noreply.github.com>
Co-authored-by: RiteshHMCTS <74713687+RiteshHMCTS@users.noreply.github.com>

* common lib version updated

* toolkit version updated

* toolkit version updated

---------

Co-authored-by: OgunyemiO <142920130+OgunyemiO@users.noreply.github.com>
Co-authored-by: connorpgpmcelroy <74015088+connorpgpmcelroy@users.noreply.github.com>
Co-authored-by: 54687 <61242337+hmcts-jenkins-j-to-z[bot]@users.noreply.github.com>
Co-authored-by: Andy Wilkins <49269487+andywilkinshmcts@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants