-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ex UI 1782 rework case role allocation screens to allow allocate to me #3718
Ex UI 1782 rework case role allocation screens to allow allocate to me #3718
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ens-to-allow-allocate-to-me
src/role-access/containers/allocate-role/choose-role/choose-role.component.ts
Show resolved
Hide resolved
…ens-to-allow-allocate-to-me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would personally not have change the name of the enumeration item, I would just have changed it's value, but what you've done is basically fine. You do need to fix the tests, rather than just disabling them
src/role-access/containers/allocate-role/choose-role/choose-role.component.spec.ts
Outdated
Show resolved
Hide resolved
src/role-access/containers/allocate-role/choose-role/choose-role.component.ts
Show resolved
Hide resolved
…se-role-allocation-screens-to-allow-allocate-to-me' into EXUI-1782-Rework-case-role-allocation-screens-to-allow-allocate-to-me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are passing now?
…ens-to-allow-allocate-to-me
4434f68
…ens-to-allow-allocate-to-me
…ens-to-allow-allocate-to-me
…ens-to-allow-allocate-to-me
* Ex UI 1782 rework case role allocation screens to allow allocate to me (#3718) * changes Reserve to me label to Allocate to me * role category filtering removed from the choose-role component * commented unrelated unit tests * comment out unrelated unit tests * yarn audit * proposed fix for functional test failure * yarn audit * Unit tests fix based on PR review * pipeline build failure fixes --------- Co-authored-by: RiteshHMCTS <74713687+RiteshHMCTS@users.noreply.github.com> Co-authored-by: Ritesh Dsouza <ritesh.dsouza@HMCTS.net> * Add fix for caseworker names not appearing in task lists (#3751) * Add fix for caseworker names not appearing in task lists * Updating Terraform Formatting * Update yarn-audit-known-issues * Update yarn-audit-known-issues --------- Co-authored-by: 54687 <61242337+hmcts-jenkins-j-to-z[bot]@users.noreply.github.com> Co-authored-by: RiteshHMCTS <74713687+RiteshHMCTS@users.noreply.github.com> * Bug/e UI 2028 tasks not being unassigned (#3794) * Add the new pre-sign-in caseworker calls * Fix lint issues * Create caseWorkerUserDataCacheService.spec.ts * Fix linting issues * Attempt to fix functional tests * Fix functional tests * Update caseWorkerUserDataCacheService.ts * Update caseWorkerUserDataCacheService.ts --------- Co-authored-by: Andy Wilkins <49269487+andywilkinshmcts@users.noreply.github.com> Co-authored-by: RiteshHMCTS <74713687+RiteshHMCTS@users.noreply.github.com> * common lib version updated * toolkit version updated * toolkit version updated --------- Co-authored-by: OgunyemiO <142920130+OgunyemiO@users.noreply.github.com> Co-authored-by: connorpgpmcelroy <74015088+connorpgpmcelroy@users.noreply.github.com> Co-authored-by: 54687 <61242337+hmcts-jenkins-j-to-z[bot]@users.noreply.github.com> Co-authored-by: Andy Wilkins <49269487+andywilkinshmcts@users.noreply.github.com>
Jira link (if applicable)
https://tools.hmcts.net/jira/browse/EXUI-1782
Change description
Checklist