Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "EXUI-2018" #3798

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Conversation

StoneBenHMCTS
Copy link
Contributor

Reverts #3762

This reverts commit a626101.
Copy link
Contributor

@anthonydummer anthonydummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hmcts-jenkins-j-to-z
Copy link
Contributor

Plan Result (aat)

⚠️ Resource Deletion will happen

This plan contains resource delete operation. Please check the plan result very carefully!

Plan: 0 to add, 1 to change, 1 to destroy.
  • Update
    • module.redis6-cache.azurerm_redis_cache.redis
  • Delete
    • azurerm_key_vault_secret.app_insights_connection_string
Change Result (Click me)
  # azurerm_key_vault_secret.app_insights_connection_string will be destroyed
  # (because azurerm_key_vault_secret.app_insights_connection_string is not in configuration)
  - resource "azurerm_key_vault_secret" "app_insights_connection_string" {
      - id                      = "https://rpx-aat.vault.azure.net/secrets/appinsights-connection-string-mc/2614e61a879b4789a81a54df6739a022" -> null
      - key_vault_id            = "/subscriptions/1c4f0704-a29e-403d-b719-b90c34ef14c9/resourceGroups/rpx-aat/providers/Microsoft.KeyVault/vaults/rpx-aat" -> null
      - name                    = "appinsights-connection-string-mc" -> null
      - resource_id             = "/subscriptions/1c4f0704-a29e-403d-b719-b90c34ef14c9/resourceGroups/rpx-aat/providers/Microsoft.KeyVault/vaults/rpx-aat/secrets/appinsights-connection-string-mc/versions/2614e61a879b4789a81a54df6739a022" -> null
      - resource_versionless_id = "/subscriptions/1c4f0704-a29e-403d-b719-b90c34ef14c9/resourceGroups/rpx-aat/providers/Microsoft.KeyVault/vaults/rpx-aat/secrets/appinsights-connection-string-mc" -> null
      - tags                    = {} -> null
      - value                   = (sensitive value) -> null
      - version                 = "2614e61a879b4789a81a54df6739a022" -> null
      - versionless_id          = "https://rpx-aat.vault.azure.net/secrets/appinsights-connection-string-mc" -> null
    }

  # module.redis6-cache.azurerm_redis_cache.redis will be updated in-place
  ~ resource "azurerm_redis_cache" "redis" {
        id                            = "/subscriptions/1c4f0704-a29e-403d-b719-b90c34ef14c9/resourceGroups/rpx-mc-redis6-cache-aat/providers/Microsoft.Cache/redis/xui-webapp-aat"
        name                          = "xui-webapp-aat"
        tags                          = {
            "application"         = "expert-ui"
            "autoShutdown"        = "true"
            "builtFrom"           = "https://github.com/HMCTS/rpx-xui-webapp.git"
            "businessArea"        = "CFT"
            "contactSlackChannel" = "#xui-pipeline"
            "environment"         = "staging"
            "managedBy"           = "Expert UI"
        }
        # (21 unchanged attributes hidden)

      ~ redis_configuration {
          ~ maxfragmentationmemory_reserved         = 1330 -> 642
          ~ maxmemory_delta                         = 1330 -> 642
          ~ maxmemory_reserved                      = 1330 -> 642
            # (8 unchanged attributes hidden)
        }
    }

Plan: 0 to add, 1 to change, 1 to destroy.

Changes to Outputs:
  - appInsightsConnectionString   = (sensitive value) -> null

@hmcts-jenkins-j-to-z
Copy link
Contributor

Plan Result (prod)

⚠️ Resource Deletion will happen

This plan contains resource delete operation. Please check the plan result very carefully!

Plan: 0 to add, 1 to change, 1 to destroy.
  • Update
    • module.redis6-cache.azurerm_redis_cache.redis
  • Delete
    • azurerm_key_vault_secret.app_insights_connection_string
Change Result (Click me)
  # azurerm_key_vault_secret.app_insights_connection_string will be destroyed
  # (because azurerm_key_vault_secret.app_insights_connection_string is not in configuration)
  - resource "azurerm_key_vault_secret" "app_insights_connection_string" {
      - id                      = "https://rpx-prod.vault.azure.net/secrets/appinsights-connection-string-mc/2b71ffdbfe4844aeb79bd893d815cc94" -> null
      - key_vault_id            = "/subscriptions/8999dec3-0104-4a27-94ee-6588559729d1/resourceGroups/rpx-prod/providers/Microsoft.KeyVault/vaults/rpx-prod" -> null
      - name                    = "appinsights-connection-string-mc" -> null
      - resource_id             = "/subscriptions/8999dec3-0104-4a27-94ee-6588559729d1/resourceGroups/rpx-prod/providers/Microsoft.KeyVault/vaults/rpx-prod/secrets/appinsights-connection-string-mc/versions/2b71ffdbfe4844aeb79bd893d815cc94" -> null
      - resource_versionless_id = "/subscriptions/8999dec3-0104-4a27-94ee-6588559729d1/resourceGroups/rpx-prod/providers/Microsoft.KeyVault/vaults/rpx-prod/secrets/appinsights-connection-string-mc" -> null
      - tags                    = {} -> null
      - value                   = (sensitive value) -> null
      - version                 = "2b71ffdbfe4844aeb79bd893d815cc94" -> null
      - versionless_id          = "https://rpx-prod.vault.azure.net/secrets/appinsights-connection-string-mc" -> null
    }

  # module.redis6-cache.azurerm_redis_cache.redis will be updated in-place
  ~ resource "azurerm_redis_cache" "redis" {
        id                            = "/subscriptions/8999dec3-0104-4a27-94ee-6588559729d1/resourceGroups/rpx-mc-redis6-cache-prod/providers/Microsoft.Cache/redis/xui-webapp-prod"
        name                          = "xui-webapp-prod"
        tags                          = {
            "application"         = "expert-ui"
            "builtFrom"           = "https://github.com/HMCTS/rpx-xui-webapp.git"
            "businessArea"        = "CFT"
            "contactSlackChannel" = "#xui-pipeline"
            "environment"         = "production"
            "managedBy"           = "Expert UI"
        }
        # (21 unchanged attributes hidden)

      ~ redis_configuration {
          ~ maxfragmentationmemory_reserved         = 1330 -> 642
          ~ maxmemory_delta                         = 1330 -> 642
          ~ maxmemory_reserved                      = 1330 -> 642
            # (8 unchanged attributes hidden)
        }
    }

Plan: 0 to add, 1 to change, 1 to destroy.

Changes to Outputs:
  - appInsightsConnectionString   = (sensitive value) -> null

@StoneBenHMCTS StoneBenHMCTS merged commit 9cc068b into feature/CR-84-Sprint-PI-32 Jul 12, 2024
3 checks passed
@StoneBenHMCTS StoneBenHMCTS deleted the revert-3762-EXUI-2018 branch July 12, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants