-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VIH-10215 Response contracts update #651
Merged
will-craig
merged 14 commits into
master
from
feature/VIH-10762-remove-redundant-contracts
Jul 2, 2024
Merged
VIH-10215 Response contracts update #651
will-craig
merged 14 commits into
master
from
feature/VIH-10762-remove-redundant-contracts
Jul 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in booking api, removed some redundant contacts so there is only one ParticipantResponse
…e service change. These properties will be removed altogether in upcoming changes
…VIH-10762-remove-redundant-contracts
…nt-contracts' into feature/VIH-10762-remove-redundant-contracts
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it does look ok, just left a few questions, may just be a misunderstanding on my part
oliver-scott
approved these changes
Jun 21, 2024
will-craig
changed the title
VIH-10762 Response contracts update
VIH-10215 Response contracts update
Jun 24, 2024
ronaldmalone
approved these changes
Jul 1, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified participant response contracts by removing data duplicated in booking api, removed some redundant contacts so there is only one ParticipantResponse